Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTML output #85

Open
aayushmau5 opened this issue Feb 11, 2022 · 15 comments
Open

Add support for HTML output #85

aayushmau5 opened this issue Feb 11, 2022 · 15 comments
Labels
enhancement New feature or request good first issue Good for newcomers stale

Comments

@aayushmau5
Copy link
Member

This library currently supports JSON, & YAML output.

We need to support HTML output.

Check #75

The format of HTML output

The goal is to generate a HTML(or jsx?) that can be reused in AsyncAPI studio as well. Thus, we need to have a detailed discussion on the format.

@Khadeeejah
Copy link

@aayushmau5 hello, iwould like to work on this

@aayushmau5
Copy link
Member Author

@Khadeeejah Awesome! Issue is yours, but first, I think we need to have a detailed discussion on what the HTML should look like 🤔

@aayushmau5
Copy link
Member Author

aayushmau5 commented Apr 25, 2022

The goal is to generate a HTML(or jsx?) that can be reused in AsyncAPI studio as well. Thus, we need to have a detailed discussion on the format.

CC @magicmatatjahu what do you think the format should look like?

I'll see what I can come up with. @Khadeeejah it's a good opportunity to checkout AsyncAPI studio as well 🙂

@Khadeeejah
Copy link

Please let me know what you come up with

@aayushmau5
Copy link
Member Author

Sorry for the late reply.

I'm just throwing around some ideas, so feel free to suggest or make some changes.

I think the HTML structure will look very similar to the markdown output. Ex.

<h1>Diff</h1>

<h2>All Breaking Changes</h2>

Changes inside code blocks?

<p><span bold>Action :</span>Add</p>
<p><span bold>Path :</span>/some/path</p>
<p bold>Before :</p>
<code syntaxHighlight>
  {
  Hello: "world"
  }
</code>
<p bold>After :</p>
<code syntaxHighlight>
  {
  Hello: "world"
  }
</code>


<h2>All Non-Breaking Changes</h2>
....

<h2>All Unclassified Changes</h2>
....

Some features may be:

  • Syntax highlighting in code block(not sure what approach we are taking for styling though)
  • Instead of having After and Before, we can perhaps have the changes in a single code blocks with highlights what's changed. Just like github does in diff output.

This is what I came up with.

My current question is what approach are we taking to styling?(Should we include style sheets in the output, having class names in html structure so users can make changes based on class names, some other approach?)

CC @derberg Need some suggestions here :)

@derberg
Copy link
Member

derberg commented May 9, 2022

sorry @aayushmau5 but I'm the worst person to ask for styling feedback 😄
what I know though is that I like to copy from others if I do not have an idea on my own 😄

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added stale and removed stale labels Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Jan 7, 2023

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jan 7, 2023
@sambhavgupta0705
Copy link
Member

Hi @aayushmau5 is this issue still active?

@github-actions github-actions bot removed the stale label Feb 8, 2023
@aayushmau5
Copy link
Member Author

@sambhavgupta0705 yes! You want to take this up? Let me know if you need any help.

@sambhavgupta0705
Copy link
Member

yeahh @aayushmau5 I need some more clarity on this issue.

@barat-sh
Copy link

Hi @aayushmau5 is this issue still active? i can contribute.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 27, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2023
@aayushmau5 aayushmau5 reopened this Sep 3, 2024
@imabp
Copy link
Member

imabp commented Oct 27, 2024

@aayushmau5 do you need a static html file, which can be displayed on studio? I want to understand the requirement here.

The goal is to generate a HTML(or jsx?)

As you mentioned in issue description about jsx. If we go with jsx method, we need to use transpilers, and make necessary changes in asyncapi studio as well, whereas, static file serve, do not need extra efforts

Before we start, I wanted to know the requirements, how do we want to present it in studio?

@imabp
Copy link
Member

imabp commented Oct 27, 2024

In my mind, I want to have something like this. This will essentially, take care of generate of static html file as an asset, which can be used in CIs for. visualization or in studio. What are your thoughts? @aayushmau5

cli generate-diff document1 document2 --html --path "/"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers stale
Projects
None yet
Development

No branches or pull requests

6 participants