Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create rule asyncapi3-channel-no-query-nor-fragment for v3 core ruleset #1051

Conversation

aeworxet
Copy link
Contributor

This PR creates the rule asyncapi3-channel-no-query-nor-fragment for the v3 core ruleset.

Resolves #1018

Copy link

changeset-bot bot commented Aug 11, 2024

🦋 Changeset detected

Latest commit: d96dc4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@smoya
Copy link
Member

smoya commented Sep 2, 2024

This PR adds a new functionality, so it should be released as, at least, a minor.

It might seem it introduces a breaking change, and somehow, it does since some v3 docs may be invalid now. But nothing the spec doesn't mention, so i would release it as minor.

Anyway, pinging other maintainers @jonaslagoni @magicmatatjahu

@aeworxet
Copy link
Contributor Author

aeworxet commented Sep 5, 2024

@smoya
Should I use a minor version for this PR only and create a new minor version for each issue from the #1016 (comment) list, or should I use one minor version to annotate all of them (create one PR with all of those rules?)

@smoya
Copy link
Member

smoya commented Sep 5, 2024

@smoya
Should I use a minor version for this PR only and create a new minor version for each issue from the #1016 (comment) list, or should I use one minor version to annotate all of them (create one PR with all of those rules?)

It is up to you. But don't worry about releasing multiple minors in a small period of time. Its all good.

@aeworxet aeworxet force-pushed the chore-create-the-rule-asyncapi3-channel-no-query-nor-fragment-for-the-v3-core-ruleset branch from 22aed2f to 2d939ae Compare September 6, 2024 07:24
Copy link

sonarcloud bot commented Sep 10, 2024

@aeworxet aeworxet changed the title chore: create rule asyncapi3-channel-no-query-nor-fragment for v3 core ruleset feat: create rule asyncapi3-channel-no-query-nor-fragment for v3 core ruleset Sep 10, 2024
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

@smoya
Copy link
Member

smoya commented Sep 10, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit bebbd39 into asyncapi:master Sep 10, 2024
13 checks passed
@aeworxet aeworxet deleted the chore-create-the-rule-asyncapi3-channel-no-query-nor-fragment-for-the-v3-core-ruleset branch September 13, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the rule asyncapi3-channel-no-query-nor-fragment for the v3 core ruleset
3 participants