-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create rule asyncapi3-channel-no-query-nor-fragment
for v3 core ruleset
#1051
Conversation
🦋 Changeset detectedLatest commit: d96dc4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This PR adds a new functionality, so it should be released as, at least, a minor. It might seem it introduces a breaking change, and somehow, it does since some v3 docs may be invalid now. But nothing the spec doesn't mention, so i would release it as minor. Anyway, pinging other maintainers @jonaslagoni @magicmatatjahu |
@smoya |
It is up to you. But don't worry about releasing multiple minors in a small period of time. Its all good. |
…the v3 core ruleset
22aed2f
to
2d939ae
Compare
Quality Gate passedIssues Measures |
asyncapi3-channel-no-query-nor-fragment
for v3 core rulesetasyncapi3-channel-no-query-nor-fragment
for v3 core ruleset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀🌔
/rtm |
This PR creates the rule
asyncapi3-channel-no-query-nor-fragment
for the v3 core ruleset.Resolves #1018