docs: fix Node req in develop README section #655
Conversation
smoya
requested review from
fmvilas,
magicmatatjahu,
jonaslagoni,
derberg and
asyncapi-bot-eve
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
| 1. Write code and tests. | ||
| 1. Make sure all tests pass `npm test` | ||
| 1. Make sure code is well formatted and secure `npm run lint` | ||
| 1. Make sure you are using Node.js 15 or higher and npm 7 or higher. |
There was a problem hiding this comment.
| 1. Make sure you are using Node.js 15 or higher and npm 7 or higher. | |
| 1. Make sure you are using Node.js 16 or higher and npm 7 or higher. |
15 has only 0.5 year of support, 16 has 2 years.
There was a problem hiding this comment.
does it mean we drop support for Node 14? isn't it a breaking change?
There was a problem hiding this comment.
On the one hand it is, but on the other it is not. You can always have node 14 but npm in 7 version - you have to install npm manually.
There was a problem hiding this comment.
Would it make sense to release this in the 2.0 version of the parser then? We could say "we support >=16 but it might work in older versions" kinda message.
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
|
Already moved to node v16 in parser v2, closing. |
Description
I noticed the right combo should be Node >=15, NPM >= 7., according to https://nodejs.org/en/download/releases/
Related issue(s)
npm install. #427