Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve image type detection in build-rss.js #3357

Open
coderabbitai bot opened this issue Nov 1, 2024 · 2 comments · May be fixed by #3396
Open

Improve image type detection in build-rss.js #3357

coderabbitai bot opened this issue Nov 1, 2024 · 2 comments · May be fixed by #3396
Assignees
@akshatnema
Labels
enhancement good first issue Good for newcomers

Comments

@coderabbitai
Copy link

coderabbitai bot commented Nov 1, 2024

As discussed in PR #3101 (#3101 (comment)), we need to improve the image type detection logic in build-rss.js to handle more image formats and enhance maintainability.

This issue is created to track this improvement as per the discussion with @akshatnema.
@lakshaydewan
Copy link

PR #3359 solves the issue, needs review.

@coderabbitai coderabbitai bot mentioned this issue Nov 1, 2024
Closed
@SahilDahekar SahilDahekar linked a pull request Nov 14, 2024 that will close this issue
Open
@parthgupta9
Copy link

hello , could i assign this issue..i have read the code of build-rss.js and come in conclusion to use mime library instead of using hardcoded image detection. it will help to Simplifies the logic for determining image types and also enhance compatibility with additional image formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshatnema akshatnema

Labels
enhancement good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added support for additional image formats in build-rss.js SahilDahekar/website
4 participants
@akshatnema @anshgoyalevil @parthgupta9 @lakshaydewan