Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose privacy mode in public API #6

Open
antoninbiret opened this issue Jan 13, 2023 · 0 comments
Open

Expose privacy mode in public API #6

antoninbiret opened this issue Jan 13, 2023 · 0 comments

Comments

@antoninbiret
Copy link

antoninbiret commented Jan 13, 2023

For now the public API accepts a String for the privacy mode setter however you internally deal with a struct PA.Privacy.Mode. It would probably be better to expose this struct or expose an enum (as the Privacy.VisitorMode in the ATInternet SDK) in order to let the compiler check if the privacy mode is managed. We did the mistake while migrating from ATInternet as the underlying string for the privacy mode does not use the same case.

Looking forward to read your feedback.

Antonin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant