Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If selva child process exits with error, node process exits with 0 #477

Open
youzi opened this issue Jul 4, 2023 · 1 comment
Open

If selva child process exits with error, node process exits with 0 #477

youzi opened this issue Jul 4, 2023 · 1 comment

Comments

@youzi
Copy link
Contributor

youzi commented Jul 4, 2023

This is wrong in cases where we are using the exit code to check if service exited with error or not.

I think it's handled incorrect here: server/src/server/index.ts:215

@youzi
Copy link
Contributor Author

youzi commented Jul 4, 2023

eg logs:

Jun 20 08:58:41 xxx node[1531]: /home/ec2-user/shared_modules/e2abc5edcce458989fffbcdb173d7e727d35f4ee/dist/server/../../modules/binaries/linux_x64/redis-server-selva --port,4003,--protected-mode,no,--dir,/home/ec2-user/services/env-db-sub-manager/tmp,--loadmodule,/home/ec2-user/shared_modules/e2abc5edcce458989fffbcdb173d7e727d35f4ee/modules/binaries/linux_x64/selva.so
Jun 20 08:58:41 xxx node[1531]: env-db-sub-manager-60c6cd: Process exiting with code 1
Jun 20 08:58:41 xxx node[1531]: env-db-sub-manager-60c6cd: exited with 0
Jun 20 08:58:41 xxx node[1531]: env-db-sub-manager-60c6cd: closed with 0

@youzi youzi changed the title If selva native module exits with error, node process exits with 0 If selva child process exits with error, node process exits with 0 Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant