Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading never stops at some pages when going back in history #2038

Closed
aartaka opened this issue Jan 21, 2022 · 10 comments
Closed

Loading never stops at some pages when going back in history #2038

aartaka opened this issue Jan 21, 2022 · 10 comments
Labels
bug history Related to history handling.

Comments

@aartaka
Copy link
Contributor

aartaka commented Jan 21, 2022

This started happening after redirection skipping fix. Some non-redirected pages stopped being recorded in history and thus history now often skips pages when going back.

To reproduce, open any page listing several links, like https://github.com/atlas-engineer/nyxt/issues, and try following several links and getting back in history. At some point, It'll start getting you to issue pages and behave in a seemigly random way.

buffer-history-tree will also show strange sequences of pages with no apparent connection to how you browsed those.

Anyone having the same experience?
@aartaka aartaka added bug 3-series Related to releases whose major version is 3. history Related to history handling. labels Jan 21, 2022
@aartaka aartaka self-assigned this Jan 21, 2022
@Ambrevar
Copy link
Member

I can't reproduce, although I have something else: the load spinner never stops when navigating history on GitHub. Maybe due to some JavaScript?
Because of this, the history entry of the spinning pages does not get created.

@aartaka
Copy link
Contributor Author

aartaka commented Jan 22, 2022

Hmmm, that could be the reason for history incompleteness, yes.

For me, it does stop, but only after some ten seconds, which is just too much :/

@aartaka
Copy link
Contributor Author

aartaka commented Jan 24, 2022

Ah, I doesn't stop, you're right!

@aartaka aartaka changed the title History skips pages when going back/forward Loading never stops at some pages when going back in history Jan 24, 2022
@aartaka aartaka removed their assignment Jan 24, 2022
@Ambrevar
Copy link
Member

Any idea when this started happening?

@aadcg
Copy link
Member

aadcg commented Mar 23, 2023

This one seems like an important one.

@aartaka
Copy link
Contributor Author

aartaka commented Mar 24, 2023

Yes.

@aadcg
Copy link
Member

aadcg commented Apr 23, 2023

Is anyone looking into this one?

@Ambrevar
Copy link
Member

Me, not immediately.

@aadcg
Copy link
Member

aadcg commented Apr 24, 2023

No pressure @Ambrevar!

@jmercouris jmercouris removed the 3-series Related to releases whose major version is 3. label May 2, 2023
@aadcg
Copy link
Member

aadcg commented Feb 10, 2025

No longer important, due to #3598.

@aadcg aadcg closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug history Related to history handling.
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Ambrevar @jmercouris @aadcg @aartaka