Fix inability to open Gmail when using reduce-tracking-mode.

[shamazmazum]

This PR fixes #3402. Fix strip-tracking-parameters which was damaging some kind of URLs.

[shamazmazum]

Oops, I am sorry. Gmail opens fine, but search queries which contain spaces are now causing an endless loop. Looking for another solution.

[aadcg]

Thanks for the fix @shamazmazum. I've left some comments.

Please add a changelog entry as a separate commit.

[aadcg]

I'd suggest moving the comment from the codebase to the commit message. Also, the specific case of gmail could be used as a test for reduce-tracking-mode. The commit message should mention, in more general terms, the root of the issue instead of focusing in this concrete case.

[aadcg]

@shamazmazum I took a brief look at the recent changes. Would it make sense to add a variant of quri:url-encode-params or refactor it in such a way that percent-encoding is optional? I am a maintainer of quri.

[shamazmazum]

@aadcg Where to put a new entry in the changelog? 4.0.0? 3.11.7? What is the next release? 3.11.7, as I presume.

Few comments on code:

• The comment should be in the code, as it is tempting for someone not familiar with the situation to change it back to using quri. It should be clear why one should not do so.
• url-filter-params is good at least for debugging. It does not require a string to be wrapped in two layers of abstraction.

I agree with the rest.

[aadcg]

@shamazmazum 3.11.7, thanks.

Your argumentation makes sense.

[shamazmazum]

@shamazmazum I took a brief look at the recent changes. Would it make sense to add a variant of quri:url-encode-params or refactor it in such a way that percent-encoding is optional? I am a maintainer of quri.

Yes, it would be better. I'll take a look at it. It can take some time, though :)

[aadcg]

Yes, it would be better. I'll take a look at it. It can take some time, though :)

No pressure! Thanks.

[shamazmazum]

OK, I've added a PR to quri, waiting for approval. After it is merged, I'll modify this PR to use quri for correct handling of parameters.

[aadcg]

Sounds good @shamazmazum, thanks.

[shamazmazum]

I think, it's done :)

[aadcg]

@shamazmazum I've merged with PR with minor changes via commit 6a7afab, thanks!