Skip to content
This repository has been archived by the owner on Sep 21, 2022. It is now read-only.

javascript: null is white, should be like the booleans #60

Open
tunnckoCore opened this issue Feb 28, 2017 · 6 comments
Open

javascript: null is white, should be like the booleans #60

tunnckoCore opened this issue Feb 28, 2017 · 6 comments

Comments

@tunnckoCore
Copy link
Contributor

foo(null, false, true, 123, res)

2017-02-28-08 19 27_330x72_scrot

@silvestreh
Copy link
Member

For some reason I cannot see screenshots uploaded to cloud.githubusercontent.com (I can't even see my own profile pic) 😕

@tunnckoCore
Copy link
Contributor Author

Get that ;d https://cdn.pbrd.co/images/DRGB4L5hc.png

@silvestreh
Copy link
Member

Just curious… What's the reasoning behind making it look like a boolean? Sublime's version makes it the same color as booleans, but does it make sense? I mean, it's a value that represents the intentional absence of value… it should look different, right?

I'm not saying white is OK, but I think we can come up with something different maybe 🤷‍♂️

@tunnckoCore
Copy link
Contributor Author

meh, yea, may be lighter than bools, but not something different.

yea, it can make sense, but habits

@silvestreh
Copy link
Member

I'm not exactly a fan of mixing italics in my code, but what about something like:

captura de pantalla 2017-02-28 a las 16 20 25

@tunnckoCore
Copy link
Contributor Author

tunnckoCore commented Feb 28, 2017

Me too 😅 , kinda don't like it too. That's why i just want to match at least as much as possible to the Sublime's - because the eyes and the years usage.

edit: even in github and prism it isn't with different color.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants