Improve error message to identify exact problem on enlist failure. #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed change improves the error message received for cases where the enlist fails in the AtomikosJdbcConnectionProxy.
Currently this class says for all transaction states that are not ACTIVE or MARKED_ABORT that a timeout happened. This is misleading, we particularly had a case where the enlist failed not due to a timeout but because JPA called a setRollbackOnly because a flush failed on the EntityManager because of an SQL Error (value was too large for a specific column, JPA implementation was Eclipselink).
So here we propose to add the actual transaction state to the error message to get a better hint on what might be the problem.