Reduce binary size by avoiding aggressive inlining of term decoding

This leaves more room for libs and programs for smaller targets Signed-off-by: Paul Guyot <[email protected]>
atomvm · May 1, 2023 · 558e5ff · 558e5ff
1 parent 50f8236
commit 558e5ff
Show file tree

Hide file tree

Showing 4 changed files with 473 additions and 461 deletions.
diff --git a/src/libAtomVM/defaultatoms.c b/src/libAtomVM/defaultatoms.c
@@ -124,6 +124,9 @@ static const char *const get_tail_atom = "\x8" "get_tail";
 static const char *const equal_colon_equal_atom = "\x3" "=:=";
 static const char *const signed_atom = "\x6" "signed";
 
+static const char *const no_fail_atom = "\x7" "no_fail";
+static const char *const resume_atom = "\x6" "resume";
+
 void defaultatoms_init(GlobalContext *glb)
 {
     int ok = 1;
@@ -232,6 +235,9 @@ void defaultatoms_init(GlobalContext *glb)
     ok &= globalcontext_insert_atom(glb, equal_colon_equal_atom) == EQUAL_COLON_EQUAL_ATOM_INDEX;
     ok &= globalcontext_insert_atom(glb, signed_atom) == SIGNED_ATOM_INDEX;
 
+    ok &= globalcontext_insert_atom(glb, no_fail_atom) == NO_FAIL_ATOM_INDEX;
+    ok &= globalcontext_insert_atom(glb, resume_atom) == RESUME_ATOM_INDEX;
+
     if (!ok) {
         AVM_ABORT();
     }

diff --git a/src/libAtomVM/defaultatoms.h b/src/libAtomVM/defaultatoms.h
@@ -133,7 +133,10 @@ extern "C" {
 #define EQUAL_COLON_EQUAL_ATOM_INDEX 84
 #define SIGNED_ATOM_INDEX 85
 
-#define PLATFORM_ATOMS_BASE_INDEX 86
+#define NO_FAIL_ATOM_INDEX 86
+#define RESUME_ATOM_INDEX 87
+
+#define PLATFORM_ATOMS_BASE_INDEX 88
 
 #define FALSE_ATOM TERM_FROM_ATOM_INDEX(FALSE_ATOM_INDEX)
 #define TRUE_ATOM TERM_FROM_ATOM_INDEX(TRUE_ATOM_INDEX)
@@ -241,6 +244,9 @@ extern "C" {
 #define EQUAL_COLON_EQUAL_ATOM TERM_FROM_ATOM_INDEX(EQUAL_COLON_EQUAL_ATOM_INDEX)
 #define SIGNED_ATOM TERM_FROM_ATOM_INDEX(SIGNED_ATOM_INDEX)
 
+#define NO_FAIL_ATOM TERM_FROM_ATOM_INDEX(NO_FAIL_ATOM_INDEX)
+#define RESUME_ATOM TERM_FROM_ATOM_INDEX(RESUME_ATOM_INDEX)
+
 void defaultatoms_init(GlobalContext *glb);
 
 void platform_defaultatoms_init(GlobalContext *glb);

diff --git a/src/libAtomVM/module.c b/src/libAtomVM/module.c
@@ -292,7 +292,12 @@ Module *module_new_from_iff_binary(GlobalContext *global, const void *iff_binary
         mod->free_literals_data = 0;
     }
 
-    mod->end_instruction_ii = read_core_chunk(mod);
+    int r = read_core_chunk(mod);
+    if (r < 0) {
+        module_destroy(mod);
+        return NULL;
+    }
+    mod->end_instruction_ii = r;
 
     return mod;
 }