Add support for list_to_integer/2 #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub-gonet
commented
Oct 11, 2024
jakub-gonet
force-pushed
the
jgonet/list-to-binary-2
branch
from
736aa51
to
05d3ea3
Compare
bettio
requested changes
Oct 11, 2024
|
An additional request: please fixup existing commit rather than making an additional one, and if you can rebase on latest |
Signed-off-by: Jakub Gonet <[email protected]>
jakub-gonet
force-pushed
the
jgonet/list-to-binary-2
branch
from
05d3ea3
to
7dd50db
Compare
|
Sorry for formatting, my editor wasn't fully setup for AVM. How releases work? You do development on latest release branch and copy commit over to |
We do safe additions and fixes on release-0.6 branch, while new breaking changes (and any risky change) in main. I merge release-0.6 into main once a week. |
bettio
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on unix port of AtomVM, some interactive testing and
./test-erlang test_list_to_integer.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later