Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of Polymer themes #3

Open
carlosbkm opened this issue Jul 6, 2015 · 2 comments
Open

Use of Polymer themes #3

carlosbkm opened this issue Jul 6, 2015 · 2 comments

Comments

@carlosbkm
Copy link

Hi,

Thanks a lot for your great work with meteor-elements. I'm taking your code meteor-polymer-music as a base for creating a Polymer Starter Kit style project. However, I would like to use Polymer theming and I tried to do it tis way:

  1. Added an app-theme.html file under the components folder.
  2. Added after all the other imports in the main app file (music-app.html)

Unfortunately that doesn't work. Do you know a way of using polymer themes as those in https://polymerthemes.com/ ?

Thanks in advance.

@atoy40
Copy link
Owner

atoy40 commented Jul 7, 2015

Hello,

I suppose the theme file contains a style "custom" tag.
A first idea : are you sure your browser hasn't cached music-app.html ? because meteor set the expire to never for public files. To "fix" it, when developing, I open the chrome dev tool, and check "disable cache" in the the network tab.

Anthony.

@carlosbkm
Copy link
Author

Hi Anthony,

I checked "disable cache" in Chrome as you recommended, unfortunately it seems that the issue has nothing to do with that. The thing is, when I hardcode the style directly in the music-app.html file just after "dom-module" tag like this:

captura de pantalla 2015-07-07 a las 13 52 33

Then is taking the styles properly and I can see the application look as intended:

captura de pantalla 2015-07-07 a las 13 54 45

However, if I link the file as it should be, instead of hardcoding the style :

captura de pantalla 2015-07-07 a las 13 51 01

Then the styles are not correctly propagated down in the DOM hierarchy, and for example the menu is not taking the styles. Just to make sure, the code in app-theme.html is the same I hardcoded in the working example:

captura de pantalla 2015-07-07 a las 13 53 48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants