Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability for sync verb handler to skip delete commit entries to be sent to client #2097

Open
murali-shris opened this issue Sep 19, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@murali-shris
Copy link
Member

Is your feature request related to a problem? Please describe.

#2066
"Excessive Syncing of Deleted Keys: New clients must sync all keys, including numerous deletions, leading to significant time and space inefficiencies."

Describe the solution you'd like

  • introduce a flag skipDeletes in sync verb handler.
  • do not send keys that were eventually deleted in the sync list to client

Describe alternatives you've considered

No response

Additional context

No response

@murali-shris murali-shris added the enhancement New feature or request label Sep 19, 2024
@murali-shris murali-shris self-assigned this Sep 19, 2024
@murali-shris
Copy link
Member Author

Complete some of the changes on server to skip delete entries.
While writing tests encountered a bug in _acceptKey in commit log keystore.
#2115
Will fix the bug and then resume work on this feature

@murali-shris
Copy link
Member Author

Server changes:
#2097
Client changes:
https://github.com/atsign-foundation/at_client_sdk/tree/sync_skip_deletes
End2End testing in progress.Once successful, will run performance tests.
Server PR to be merged first once performance results are good

@murali-shris
Copy link
Member Author

Implemented skipUntil changes and extensive unit tests on server
#2131
Changes in at_client in progress

@murali-shris
Copy link
Member Author

atsign-foundation/at_client_sdk#1432
At client changes complete.Will re-open PR once benchmarking tests are complete and server changes are merged
Performance bench marking in progress
https://docs.google.com/spreadsheets/d/1Mc4GFe2-xZ4CZImBa3xWiAufq7PaOm42c3pItTYSPXQ/edit?gid=0#gid=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant