Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[at_onboarding] [MacOS] Need a feature allow user share atSign between apps #459

Open
sonle-geekyants opened this issue Aug 5, 2022 · 37 comments
Assignees
Labels
0 SP No SP's assigned enhancement New feature or request PR43 Aug 2022 Sprint Planning PR44 Aug 2022 Sprint Planning PR45 Aug | Sept 2022 Sprint Planning PR46 Sept | Oct Sprint Planning PR47 Oct Sprint Planning PR48 Oct 2022 Sprint Planning PR49 Oct | Nov 2022 Sprint Planning PR50 Nov 2022 Sprint Planning PR51 Nov 2022 Sprint Planning PR52 Nov | Dec 2022 Sprint Planning PR53 Jan 2023 Sprint Planning

Comments

@sonle-geekyants
Copy link
Contributor

sonle-geekyants commented Aug 5, 2022

In the new onboarding widget, we can give the user an option to share the the keychain between different apps. But this feature is only available in macos.

We need to decide whether adding this feature only on macos will be fine or not.
Currently this feature is disabled.

@sonle-geekyants sonle-geekyants added the enhancement New feature or request label Aug 5, 2022
@gkc gkc added 4 SP 4 Story Points - More than 1 day less than 3 days 3 SP 3 Story Points - 1 Day Small and removed 4 SP 4 Story Points - More than 1 day less than 3 days 3 SP 3 Story Points - 1 Day Small labels Aug 8, 2022
@ksanty ksanty added 8 SP 8 Story Points - 5 Days Large PR43 Aug 2022 Sprint Planning labels Aug 9, 2022
@nickelskevin
Copy link
Member

IMHO - making use of keys that we have available to us to improve their experience is the preferred option.

@cconstab
Copy link
Member

It would be my suggestion to make sure that the other desktops env all act the same . So that needs investigation. If they do this is a good idea.

I think we should also look into allowing multiple instances of applications so they do no step on each others hive files..

@ksanty
Copy link
Member

ksanty commented Aug 10, 2022

Leaving as a follow-up arch call discussion item

@nitesh2599
Copy link
Contributor

nitesh2599 commented Aug 11, 2022

@sonle-geekyants We will have to check a few things here :

Platform that supports share feature:

Desktop Platforms:

  • MacOS
  • Windows
  • Linux

Mobile Platforms:

  • Android
  • iOS (We will have to create ios app groups and test)

Data Related check:

  • We also need to make sure that if we use the share feature on a platform, two apps should not step on each others hive files .

@sachins-geekyants
Copy link
Contributor

Reducing SP and moving to next sprint.

@sachins-geekyants sachins-geekyants added 5 SP 5 Story Points - 3 Days Medium and removed 8 SP 8 Story Points - 5 Days Large labels Aug 22, 2022
@ksanty ksanty added the PR44 Aug 2022 Sprint Planning label Aug 23, 2022
@ksanty
Copy link
Member

ksanty commented Aug 29, 2022

Would like Gary's input when he's back

@sonle-geekyants
Copy link
Contributor Author

@gkc and @sachins-geekyants
Related to this issue:

  • MacOS: ok
  • iOS: ok. the app must add Keychain Sharing to Capabilities in XCode
  • Android: don't support. biometric_storage use KeyStore in Android and can't share between apps
  • Linux: don't support for now
  • Windows: ok.

And don't make any impact to hive data if app use share atSign.

@ksanty ksanty added the PR46 Sept | Oct Sprint Planning label Sep 20, 2022
@nitesh2599
Copy link
Contributor

Could not be worked on in this sprint, moving to next sprint.

@sonle-geekyants
Copy link
Contributor Author

sonle-geekyants commented Oct 12, 2022

I've done this task and pushed code on branch

@sachins-geekyants
Copy link
Contributor

Reducing SP and moving to next sprint for testing and deployment.

@sachins-geekyants sachins-geekyants added Sprint PR8 3 SP 3 Story Points - 1 Day Small and removed Sprint PR8 5 SP 5 Story Points - 3 Days Medium labels Oct 17, 2022
@ksanty ksanty added the PR48 Oct 2022 Sprint Planning label Oct 18, 2022
@sonle-geekyants
Copy link
Contributor Author

@ayushkumarrojha please help me test this ticket.

@sachins-geekyants sachins-geekyants added the PR51 Nov 2022 Sprint Planning label Nov 28, 2022
@sachins-geekyants
Copy link
Contributor

@sonle-geekyants @ayushkumarrojha can you update this ticket ?

@sachins-geekyants sachins-geekyants added the PR52 Nov | Dec 2022 Sprint Planning label Dec 12, 2022
@sonle-geekyants
Copy link
Contributor Author

Screen.Recording.2023-01-04.at.17.23.32.mov

I've uploaded the video @sachins-geekyants

@sachins-geekyants
Copy link
Contributor

@sonle-geekyants Can we changes @platform to atPlatform in the message appears on dialog box ?

@ksanty ksanty added the PR53 Jan 2023 Sprint Planning label Jan 9, 2023
@sonle-geekyants
Copy link
Contributor Author

@sonle-geekyants Can we changes @platform to atPlatform in the message appears on dialog box ?

Okay. I will edit it.

@sonle-geekyants
Copy link
Contributor Author

sonle-geekyants commented Jan 11, 2023

I've changed it @sachins-geekyants . Please pull the newest code and test it.
Branch:
The Wavi app: feature/enable-user-sharing
The atmospherePro app: feature/enable-user-sharing

Screen.Recording.2023-01-11.at.17.32.06.mov

@tinashe404
Copy link
Member

@sachins-geekyants @sonle-geekyants the text still says " when you use @ sign with other apps"....

Shouldnt " @ sign" be the actual atSign that is currently onboarded?

@sachins-geekyants
Copy link
Contributor

@tinashe404 This message appears before onboarding, so we don't know the atSign yet.

@tinashe404
Copy link
Member

@sachins-geekyants in that case can we change the text to say "when you use this atSign with other"

@sonle-geekyants
Copy link
Contributor Author

image

I've changed it. Could you please check again? @tinashe404

@tinashe404
Copy link
Member

@sonle-geekyants looks good

@sachins-geekyants
Copy link
Contributor

PRs have been raised for the above changes, I will assign it 0 SP till PR is reviewed.

@sachins-geekyants sachins-geekyants added 0 SP No SP's assigned and removed 3 SP 3 Story Points - 1 Day Small labels Feb 6, 2023
@sachins-geekyants
Copy link
Contributor

@sonle-geekyants can you check the status of PRs, it's still open.

@sachins-geekyants
Copy link
Contributor

user sharing is available in at_client_mobile 3.2.9.
atApps needs to be deployed with options to enable sharing atSign info across apps.

@gkc
Copy link
Contributor

gkc commented Mar 18, 2024

@sachins-geekyants @ksanty Is this still relevant, and something that needs to be worked on?

@sachins-geekyants
Copy link
Contributor

sachins-geekyants commented Mar 18, 2024

The implementation is done in at_client_mobile and onboarding_flutter.

This feature is available in atPro desktop also, for other app we can create separate tickets if required.
This can be closed.

@ksanty
Copy link
Member

ksanty commented Mar 18, 2024

user sharing is available in at_client_mobile 3.2.9. atApps needs to be deployed with options to enable sharing atSign info across apps.

Is there a screen shot showing where we find this?

@sachins-geekyants
Copy link
Contributor

user sharing is available in at_client_mobile 3.2.9. atApps needs to be deployed with options to enable sharing atSign info across apps.

Is there a screen shot showing where we find this?

This sharing atSign option

Screenshot 2024-03-19 at 4 54 23 PM

@ksanty
Copy link
Member

ksanty commented Mar 26, 2024

@sachins-geekyants can you provide guidance on when think this can be deployed? TY

I think we also need to be mindful this feature is not supported in Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 SP No SP's assigned enhancement New feature or request PR43 Aug 2022 Sprint Planning PR44 Aug 2022 Sprint Planning PR45 Aug | Sept 2022 Sprint Planning PR46 Sept | Oct Sprint Planning PR47 Oct Sprint Planning PR48 Oct 2022 Sprint Planning PR49 Oct | Nov 2022 Sprint Planning PR50 Nov 2022 Sprint Planning PR51 Nov 2022 Sprint Planning PR52 Nov | Dec 2022 Sprint Planning PR53 Jan 2023 Sprint Planning
Projects
None yet
Development

No branches or pull requests

9 participants