Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(NoPorts desktop): status alignment issues #1559

Open
XavierChanth opened this issue Nov 20, 2024 · 4 comments
Open

bug(NoPorts desktop): status alignment issues #1559

XavierChanth opened this issue Nov 20, 2024 · 4 comments
Assignees

Comments

@XavierChanth
Copy link
Member

XavierChanth commented Nov 20, 2024

Minor alignment issues on the Profile status in NoPorts desktop:

  • Status header is shifted too far left
  • The status widget space is much larger than the text takes up, so the hover is floating over the wrong spot.

CleanShot 2024-11-19 at 23 22 21@2x

Not a priority, as it doesn't impact usability. We can tackle in the next sprint.

@CurtlyCritchlow
Copy link
Contributor

@XavierChanth is there where you want the tool tip? Image

Also do we change the tooltip position of the other columns too?

@XavierChanth
Copy link
Member Author

The other columns were fine when I tested them.

The status tooltip should be centered over the content, i.e. the text and icon

@CurtlyCritchlow
Copy link
Contributor

The tooltip can only be realign vertically as shown in the previous image. Horizontal alignment is depending on the size of its parent. Once the screen is small it will hover over the content, if the screen is large it will hover at the side of the content. see video below.

my question is which view is preferred for the status column:
Small Screen

  • below the content
  • Above the content
  • Side of content
  • centered over content

Large Screen

  • below the content
  • Above the content
  • Side of content
  • centered over content

Which view is preferred for the other columns on both small and large screens

  • below the content
  • Above the content
  • Side of content
  • centered over content
Screen.Recording.2024-11-27.at.10.43.05.AM.mov

@XavierChanth
Copy link
Member Author

We can deal with later, but when we do, we can add a new parent nested inside the current parent which is only as large as the text inside it. Then the parent for the annotation will be the correct size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants