Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPT_Flutter shows disconnected but it is not #1572

Open
cconstab opened this issue Nov 26, 2024 · 4 comments · May be fixed by #1575
Open

NPT_Flutter shows disconnected but it is not #1572

cconstab opened this issue Nov 26, 2024 · 4 comments · May be fixed by #1575
Assignees
@XavierChanth
Labels
bug Something isn't working

Comments

@cconstab
Copy link
Member

Describe the bug

Connected to remote webserver which continued to be connected but the GUI said disconnected

Steps to reproduce

1.Unknown

Expected behavior

Display the actuall connectivity status ?

Screenshots

See attached video

video1641773243.mp4

Smartphones

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Were you using an atApplication when the bug was found?

No response

Additional context

No response
@cconstab cconstab added the bug Something isn't working label Nov 26, 2024
@XavierChanth
Copy link
Member

I tested this quite thoroughly when I implemented, and I can see that the SocketConnector close is called in the app logs. My assumption is that the changes to socket connector are making the connection wait for the server side to close. Since we aren’t killing a process like we do for the binaries, it’s only affecting the app using latest socket connector. Will investigate to confirm.

@cconstab
Copy link
Member Author

Do we by default use the -K keep alive as I do not see that as an option.. I have tested again and it is repeatable

@XavierChanth
Copy link
Member

It works a little differently, it didn't make sense to offer it. The built-in settings are pretty much identical to what -K does.

@XavierChanth
Copy link
Member

It will not restart the connection on failure though

@XavierChanth XavierChanth linked a pull request Nov 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XavierChanth XavierChanth

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: close socket connector with invalidating from the cache atsign-foundation/noports
3 participants
@cconstab @XavierChanth @CurtlyCritchlow