From 5ec536f706ea91855214b5e23aaacc1ee1e98f64 Mon Sep 17 00:00:00 2001
From: Alex Brown <alexandermichaelbrown@outlook.com>
Date: Wed, 28 Feb 2024 11:17:14 +1100
Subject: [PATCH] virtio-snd: improve test processes

---
 .../virtio-snd/userlevel/client_vm/cantina.c  | 11 ++++++---
 .../userlevel/client_vm/crab_rave.c           |  9 +++++--
 .../virtio-snd/userlevel/client_vm/record.c   | 24 ++++++++++++-------
 3 files changed, 31 insertions(+), 13 deletions(-)

diff --git a/examples/virtio-snd/userlevel/client_vm/cantina.c b/examples/virtio-snd/userlevel/client_vm/cantina.c
index e1ced20f0..891e10136 100644
--- a/examples/virtio-snd/userlevel/client_vm/cantina.c
+++ b/examples/virtio-snd/userlevel/client_vm/cantina.c
@@ -1,7 +1,5 @@
 #include <alsa/asoundlib.h>
  
-static char *device = "default";
-
 static const unsigned char CantinaBand60_s16le[];
 static const unsigned int CantinaBand60_s16le_len = 2646000;
 
@@ -10,11 +8,18 @@ static const unsigned int CantinaBand60_s16le_len = 2646000;
 #define RATE 22050
 #define CHUNK 2048
  
-int main(void)
+int main(int argc, char **argv)
 {
     int err;
     snd_pcm_t *handle;   
     snd_pcm_sframes_t frames;
+
+    char *device;
+    if (argc > 1) {
+        device = argv[1];
+    } else {
+        device = "default";
+    }
  
     if ((err = snd_pcm_open(&handle, device, SND_PCM_STREAM_PLAYBACK, 0)) < 0) {
         printf("Playback open error: %s\n", snd_strerror(err));
diff --git a/examples/virtio-snd/userlevel/client_vm/crab_rave.c b/examples/virtio-snd/userlevel/client_vm/crab_rave.c
index 6f333f0a7..90b03a6fe 100644
--- a/examples/virtio-snd/userlevel/client_vm/crab_rave.c
+++ b/examples/virtio-snd/userlevel/client_vm/crab_rave.c
@@ -1,7 +1,5 @@
 #include <alsa/asoundlib.h>
  
-static char *device = "default";
-
 static const unsigned char crab_rave_pcm_s16le[];
 static const unsigned int crab_rave_pcm_s16le_len = 3064320;
 
@@ -14,6 +12,13 @@ int main(void)
     int err;
     snd_pcm_t *handle;   
     snd_pcm_sframes_t frames;
+
+    char *device;
+    if (argc > 1) {
+        device = argv[1];
+    } else {
+        device = "default";
+    }
  
     if ((err = snd_pcm_open(&handle, device, SND_PCM_STREAM_PLAYBACK, 0)) < 0) {
         printf("Playback open error: %s\n", snd_strerror(err));
diff --git a/examples/virtio-snd/userlevel/client_vm/record.c b/examples/virtio-snd/userlevel/client_vm/record.c
index 5c6167b5b..2d2ca2127 100644
--- a/examples/virtio-snd/userlevel/client_vm/record.c
+++ b/examples/virtio-snd/userlevel/client_vm/record.c
@@ -1,8 +1,7 @@
 #include <alsa/asoundlib.h>
 #include <stdio.h>
  
-static char *device = "default";            /* playback device */
-unsigned char buffer[16*1024];              /* some random data */
+unsigned char buffer[16*1024];
 
 typedef struct wavfile_header_s
 {
@@ -24,7 +23,7 @@ typedef struct wavfile_header_s
 } wavfile_header_t;
 
 #define NUM_CHANNELS 1
-#define BITS_PER_SAMPLE 8
+#define BITS_PER_SAMPLE 16
 #define SUBCHUNK1SIZE 16
 
 #define SAMPLE_RATE 48000
@@ -85,19 +84,26 @@ int write_header(FILE *file_p,
 }
 
  
-int main(void)
+int main(int argc, char **argv)
 {
     int err;
     unsigned int i;
     snd_pcm_t *handle;
     snd_pcm_sframes_t frames;
+
+    char *device;
+    if (argc > 1) {
+        device = argv[1];
+    } else {
+        device = "default";
+    }
  
     if ((err = snd_pcm_open(&handle, device, SND_PCM_STREAM_CAPTURE, 0)) < 0) {
         printf("Capture open error: %s\n", snd_strerror(err));
         exit(EXIT_FAILURE);
     }
     if ((err = snd_pcm_set_params(handle,
-                      SND_PCM_FORMAT_U8,
+                      SND_PCM_FORMAT_S16,
                       SND_PCM_ACCESS_RW_INTERLEAVED,
                       1,
                       SAMPLE_RATE,
@@ -115,17 +121,19 @@ int main(void)
 
     const int buffer_count = 16;
     write_header(file, SAMPLE_RATE, sizeof(buffer) * buffer_count);
+
+    const int frame_size = 2;
  
     for (i = 0; i < buffer_count; i++) {
-        frames = snd_pcm_readi(handle, buffer, sizeof(buffer));
+        frames = snd_pcm_readi(handle, buffer, sizeof(buffer) / frame_size);
         if (frames < 0)
             frames = snd_pcm_recover(handle, frames, 0);
         if (frames < 0) {
             printf("snd_pcm_readi failed: %s\n", snd_strerror(frames));
             break;
         }
-        if (frames > 0 && frames < (long)sizeof(buffer))
-            printf("Short write (expected %li, wrote %li)\n", (long)sizeof(buffer), frames);
+        if (frames > 0 && frames < (long)sizeof(buffer) / frame_size)
+            printf("Short write (expected %li, wrote %li)\n", (long)sizeof(buffer) / frame_size, frames);
 
         fwrite(buffer, 1, sizeof(buffer), file);
     }