Json web token/ login #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enderian
reviewed
Mar 24, 2020
| @wraps(f) | ||
| def decorated(*args, **kwargs): | ||
| token = None | ||
| if 'x-access-token' in request.headers: |
There was a problem hiding this comment.
Why not use the plain Authorization: Bearer <token> headers for this? 😄
| if 'x-access-token' in request.headers: | ||
| token = request.headers['x-access-token'] | ||
| if not token: | ||
| jsonify({'message': 'Token is missing'}), 401 |
There was a problem hiding this comment.
No need to jsonify stuff here, just return the dict and the status code!
| """ | ||
| Generats a Jwt given a username more could be added in the future | ||
| """ | ||
| token = jwt.encode({'username': username, |
There was a problem hiding this comment.
I think we should rename username to sub, and also add the user's name in the name field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fill free to make any observations and i will try to fix them.