Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with getCameraMatrix() #14

Open
kalwalt opened this issue Aug 20, 2019 · 2 comments
Open

issue with getCameraMatrix() #14

kalwalt opened this issue Aug 20, 2019 · 2 comments
Assignees
Labels
bug Something isn't working C/C++ All about C and C++ code code design All about coding design javascript All about javascript related issues

Comments

@kalwalt
Copy link
Collaborator

kalwalt commented Aug 20, 2019

Actually the getCameraMatrix()

ARController.prototype.getCameraMatrix = function (nearPlane, farPlane) {
return artoolkitXjs._arwGetProjectionMatrix(nearPlane, farPlane);
};
call the exported function _arwGetProjectionMatrix but we have already a getProjectionMatrix in ARX_additions.js
https://github.com/augmentmy-world/artoolkitx/blob/3710b8236efb629c30bb189a3e9d7e196a00662e/Source/artoolkitx.js/ARX_additions.js#L12-L23
Maybe we should use this?

@kalwalt kalwalt added bug Something isn't working code design All about coding design C/C++ All about C and C++ code javascript All about javascript related issues labels Aug 20, 2019
@kalwalt kalwalt self-assigned this Aug 20, 2019
@kalwalt
Copy link
Collaborator Author

kalwalt commented Aug 20, 2019

should be:

ARController.prototype.getCameraMatrix = function (nearPlane, farPlane) {
        return artoolkitXjs.getProjectionMatrix(nearPlane, farPlane);
    };

Does it correct?

@kalwalt
Copy link
Collaborator Author

kalwalt commented Aug 29, 2019

Discussed here: #23 see the comments in the code review. I wil remove the function from ARX_additions.js because already in artoolkitX.api.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working C/C++ All about C and C++ code code design All about coding design javascript All about javascript related issues
Projects
None yet
Development

No branches or pull requests

1 participant