-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Love the Servive -- Want to offer my help [ ISSUES ] #56
Comments
Hello Felix, Thanks for your positive feedback. Your issue is very well documented, congrats. Regarding the differences you did observe between the Google version and the gdoc.pub version, I'm afraid there is not so much I can do: you have to be aware that the only info I have there is the published version of google (here) and all the differences you mention are there too. I can override some rules, but they have to be the very general case, while here, those are highly specific and I can't see how to extract some general rules out of those. Eg. even if I try to remove the As a conclusion, I would say that :
Eg. I guess if you set manually the margin below the h1, it will be reflected correctly. For images, try to play with rendering mode, or in the end, you could eventually try to add margin to the images themselves. Very hacky, I agree, but do not forget that gdoc.pub is a hack by itself. I never understood why google did not commit the little energy it required to push the "publish to the web" feature forward ... |
TL;DR: Headers and list-items (and document margin?) seem immediately fixable, other elements less simple
I tried: set it specifically in Docs and it doesn't reflect in the publication. As I said the issue is no margin is set in your CSS so it uses browser defaults, which is a problem because the spacing is already done by the publication without margins so the margins are superfluous. This is easily fixed in CSS: Consistent bullet sizes on mobile also easy with a general rule: I also saw which container has the margins (that should be relative for mobile / smaller screens) I don't know for sure if that's always the name of the container but I assume it is.
Superscript elements are a little different. I guess the class names are dynamic from google? e.g. class name might not be the same
Additionally relative font size only works if the elements are actually nested, but they are parallel :( so elements that have the superscript class and any font-size changing class can't use relative font-size (maybe you could detect superscript and manually adjust the font size 60%?) Might have to come back to this one. As you said the elements where the HTML directly apply styles is beyond my current knowledge. Does your service interact with the HTML at all? Or just apply CSS for the background (and presumably something else I didn't notice) I'd appreciate you investigating and possibly implementing those three immediately fixable issues. |
Forgot to say: perhaps it's feasible to allow the user to add their own CSS? Not sure if that's possible or not with your current system in place. |
@augnustin Have you implemented/tried anything yet? I can also respect your choice to silently ignore this. I just want this to be the best it deserves to be. |
Hello As I told you, I won't have a look, but if you want to, feel free to fork the code and give it a try. I am definitely willing to help! Cheers |
Even after re-reading your comment I see nothing implying you'd take no action I can respect it though. I wish you'd reconsider but in the end it's your vision, not mine. |
Hello augnustin,
I'm happy to see you have been engaging with people here that have submitted issues. I hope this post will be productive.
I'm inferring from these graphics on the site that your vision is the most consistent / comparable experience to the "real" doc. That is highly respectable and I want to help.
I have a live Google Doc here. (It's a guide for a mobile game I play)
For convenient navigation the document features links to the other published formats at the top.
I'd like to draw attention to several (I believe resolvable) formatting discrepancies between published formats:
Google
Publication
You can see the overflow causes a display issue and the lack of the margins on images makes these images in a series "cramped"
Google
Publication
Google
Publication
In mobile viewing:
Mobile Publication
Some of these can be immediately resolved with just css. Others require "fixing" (removing) problematic generated css styles hard coded directly to HTML elements (maybe there's a way to have priority CSS that bypasses direct HTML styles, I'm not totally update to date in my knowledge)
What I saw was images were in a span element with a fixed width (instead of auto) and overflow:hidden (instead of visible)
Please let me know if I can assist or clarify these issues in any way. Would love to test a beta version of any fixes.
Thank you!
The text was updated successfully, but these errors were encountered: