Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Incorrect scaling for CFG_SFIMU_IMU_MNTALG* config items #31

Open
bvsam opened this issue Dec 15, 2024 · 1 comment
Open

Minor: Incorrect scaling for CFG_SFIMU_IMU_MNTALG* config items #31

bvsam opened this issue Dec 15, 2024 · 1 comment

Comments

@bvsam
Copy link
Contributor

bvsam commented Dec 15, 2024

The scale member of the CFG_SFIMU_IMU_MNTALG_YAW, CFG_SFIMU_IMU_MNTALG_PITCH, and CFG_SFIMU_IMU_MNTALG_ROLL structs (all of type ubx_cfg_item_t) in ublox_dgnss_node/include/ublox_dgnss_node/ubx/ubx_cfg_item.hpp is incorrect. They're all set to .001 (which is 1e-3), when they should be set to 1e2, according to the F9 HPS 1.30 Interface description manual (which seems to be the latest version).

This seems to be a very minor issue, since the scale member is not used anywhere else in the code, but just mentioning it for reference.

@bvsam bvsam changed the title Incorrect scaling for CFG_SFIMU_IMU_MNTALG* config items Minor: Incorrect scaling for CFG_SFIMU_IMU_MNTALG* config items Dec 15, 2024
@hortovanyi
Copy link
Contributor

Yes you are correct. Must have been a cut and paste error. Its used with the F9R.

The scale in this case is what you should multiply it by for writing out to log files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants