Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract react-router-dom functionality from PR #215

Open
TimDaub opened this issue Jun 5, 2019 · 0 comments
Open

Extract react-router-dom functionality from PR #215

TimDaub opened this issue Jun 5, 2019 · 0 comments
Labels
bounty size-S total effort of ~350 DAI
Milestone

Comments

@TimDaub
Copy link
Collaborator

TimDaub commented Jun 5, 2019

Scope

  • @dmihal has added react-router-dom support in this PR Add react router #194
  • It's however entangled with other functionality currently, namely adding a TransactionStore and a config.js
  • Given that we're now working according to a specification outlined by @dmihal here, which parts of the added functionality we want in master
  • In my opinion: We can definitely use the react-router-dom integration. I'm unsure about config.js and the TransactionStore at this point. Please comment below if you have other ideas.

Deliverables

  • Given the argumentation above, extract the react-router-dom functionality in Add react router #194 and propose it at separate PR.

Notes

If you think you have a better idea on how to handle this, please feel free to comment below!

Roles

bounty gardener: @TimDaub / 10%
bounty worker: name / 75%
bounty reviewer: name / 15%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty size-S total effort of ~350 DAI
Projects
None yet
Development

No branches or pull requests

2 participants