Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve burner-wallet development by using test or local networks #218

Open
TimDaub opened this issue Jun 5, 2019 · 0 comments
Open

Improve burner-wallet development by using test or local networks #218

TimDaub opened this issue Jun 5, 2019 · 0 comments

Comments

@TimDaub
Copy link
Collaborator

TimDaub commented Jun 5, 2019

Scope

  • Currently the burner-wallet is using clevis, ganache-cli and startLocalRelay.sh to orchestrate a local network for developers.
  • This poses some problems, namely:
    • the xDai network is not simulated. Instead ganache-cli is used and ETH is sent around. Not xdai
    • Uniswap contracts are not deployed to the local network so Exchange.js won't work fully (ETH/DAI)
    • DAI/xDai won't work as there's no bridge contract available and as all the three tokens (ETH, DAI, xDai) are running on ganache-cli
  • For development with LeapDAO's network, similar problems arise. For the past month, we simply used their public testnet and Rinkeby for testing hence. It worked well with some exceptions.
  • Uniswap requires liquidity and arbitrage to allow proper token swaps. Uniswap has however an instance of their factory deployed on Rinkeby: https://docs.uniswap.io/frontend-integration/connect-to-uniswap#factory-address
  • In an ideal world, we'd work on making everything work local. For now however, that seems to be way too much work. I'm hence proposing the following deliverables.
  • I haven't done much research, but it doesn't seem like POANetwork has a xDAI testnet. I'd be happy to be proven wrong.

Deliverables

  • Create a "test mode" burner-wallet for local development where the maximum amount of functionality is testable by using test and local networks
  • Make sure that these test or local networks are easily ochestrateable by a developer. It shouldn't be more difficult than doing e.g. npm run start
  • Debugging the various components should still be possible effortless. Make sure that you're allowing the debugging of smart contracts as well as UI and network code

Here's a few paths I could see this happen. It's the workers job to deliver on the most promising path. If there's a path that I'm missing, feel free to pursue that one too! Here they are:

(1) Stay with the current configuration (ganache-cli for xDai and ETH/DAI) but improve it by:

  • adding Uniswap contracts
  • making it easier to orchestrate. e.g. Simply doing npm run start
  • Consider please that going this way, we'll still have a problem testing on LeapDAO's chain

(2) Talk to someone from POANetwork and ask them about an xDai test network. Use Rinkeby as the Rootchain + Rinkeby Uniswap contracts

(3) [Please feel free to explore other paths, but update us in the comments]

Roles

bounty gardener: @TimDaub / 15%
bounty worker: name / 75%
bounty reviewer: name / 15%

@TimDaub TimDaub added this to the Sprint 1 milestone Jun 5, 2019
@johannbarbie johannbarbie removed this from the Sprint 1 milestone Jun 13, 2019
iamonuwa pushed a commit to iamonuwa/burner-wallet that referenced this issue Jul 17, 2019
…splay-tokens

Display amount of tokens in advanced mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants