Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout doesn't revoke the refresh token(s) #1320

Open
6 tasks done
RobPethick opened this issue Nov 8, 2024 · 0 comments
Open
6 tasks done

Logout doesn't revoke the refresh token(s) #1320

RobPethick opened this issue Nov 8, 2024 · 0 comments
Labels
bug This points to a verified bug in the code

Comments

@RobPethick
Copy link

Checklist

Description

I have seen the discussion here: #1013. And the recommendation there to just get a new refresh token and then forgetting it. This isn't a correct solution for me, this will fail our security reviews. Refresh tokens should be revoked when they are done with.

In my book we shouldn't expose a revoke token method but instead we should add it to the logic within the logout method as that is the only time a client would revoke the refresh token

Reproduction

  1. Copy refresh token
  2. Logout
  3. Use refresh token
  4. Expected: refresh token can't be used, Actual: refresh token still useable

Additional context

I would be really happy to submit a PR for this improvement

auth0-spa-js version

2.1.3

Which framework are you using (React, Angular, Vue...)?

React (wrapping auth0-spa-js)

Framework version

No response

Which browsers have you tested in?

Chrome, Firefox

@RobPethick RobPethick added the bug This points to a verified bug in the code label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This points to a verified bug in the code
Projects
None yet
Development

No branches or pull requests

1 participant