Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support System.Text.Json #389

Closed
mattbarry opened this issue Apr 9, 2020 · 6 comments
Closed

Support System.Text.Json #389

mattbarry opened this issue Apr 9, 2020 · 6 comments
Labels
closed:stale Issue or PR has not seen activity recently
Milestone

Comments

@mattbarry
Copy link

Please do not report security vulnerabilities here. The Responsible Disclosure Program details the procedure for disclosing security issues.

Thank you in advance for helping us to improve this library! Your attention to detail here is greatly appreciated and will help us respond as quickly as possible. For general support or usage questions, use the Auth0 Community or Auth0 Support. Finally, to avoid duplicates, please search existing Issues before submitting one here.

By submitting an Issue to this repository, you agree to the terms within the Auth0 Code of Conduct.

Describe the problem you'd like to have solved

The System.Text.Json namespace provides functionality for serializing to and deserializing from JavaScript Object Notation (JSON). The library design emphasizes high performance and low memory allocation over an extensive feature set.

Describe the ideal solution

Remove Newtonsoft.Json from Auth0.Core.csproj and use System.Text.Json instead.

Additional context

https://docs.microsoft.com/en-us/dotnet/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to

@damieng
Copy link
Contributor

damieng commented Apr 9, 2020

This is unfortunately not possible at this time as System.Text.Json is not supported on .NET Framework 4.5.2 that we currently support.

We would need to drop support for everything prior to .NET Framework 4.7.2 for that migration to happen so we'd need to consider that for the next major based on current usage statistics for this library.

@damieng damieng added this to the 8.0.0 milestone Apr 9, 2020
@damieng
Copy link
Contributor

damieng commented Apr 9, 2020

I'm going to milestone it to the next major so we can consider it then.

@sandromastronardi
Copy link

How about Utf8Json which is one of the fastest JSON parsers? (or allow developers to select their own?)

@stale
Copy link

stale bot commented Aug 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

@stale stale bot added the closed:stale Issue or PR has not seen activity recently label Aug 31, 2020
@stale stale bot closed this as completed Sep 7, 2020
@kyrylo-prescryptive
Copy link

I still forced to use Newtonsoft.Json to work if Auth0.ManagementApi. Hope devs will support System.Text.Json

@davidruhmann
Copy link

@frederikprijck Could this issue be reopened and possibly added to a milestone now that 4.5.2 is EOL and removed from this library as of #687?

This project supports back to 4.6.2 and the latest System.Test.Json also supports back to 4.6.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:stale Issue or PR has not seen activity recently
Projects
None yet
Development

No branches or pull requests

5 participants