Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old version of Cryptiles is used #101

Open
david-nossebro opened this issue Oct 8, 2018 · 3 comments
Open

Old version of Cryptiles is used #101

david-nossebro opened this issue Oct 8, 2018 · 3 comments

Comments

@david-nossebro
Copy link

In the current version of Passport, Cryptiles version 0.2.2 is used. This version of Cryptiles contains a security issue mentioned here:
hapijs/cryptiles#34

In my project we use the tool "Black Duck Scan" which flaggs this as a critical issue.

This issue is fixed in version 4.1.2 of Cryptiles according to this page:
https://nvd.nist.gov/vuln/detail/CVE-2018-1000620

@jkomyno
Copy link

jkomyno commented Dec 28, 2018

+1 on this. The same security issue pops up when running the audit command using either npm or yarn.

audit

More info here.

@CameronJ26
Copy link

Any movement on this? This is still an issue.

@david-nossebro
Copy link
Author

I made a fix for it here:
#102

It got stuck in the review process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants