Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependency xmldom for the 2.x.x stream to solve breaking builds #132

Open
cexmmaqsood opened this issue Jul 16, 2019 · 0 comments

Comments

@cexmmaqsood
Copy link

cexmmaqsood commented Jul 16, 2019

Version: 2.13.0 (passport-wsfed-saml2)

Description of Issue

In version 2.13.0, and the 2.x.x stream, an install of my application fails due to a branch specified for the xmldom dependency instead of a tag. I imagine that the master branch on that repo was updated recently, which is what is causing the install fails.

This was corrected here 009728a

I could upgrade to 3.0.0, but I couldn't find a changelog and there are applications in production using this version, so I don't have a way of reasonably knowing if it will break the application or not without regressing.

Is it possible to get a patch for the 2.x.x stream to update this dependency to a tag vs a branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant