Merge pull request #2072 from authzed/readonly-bulk-export

make bulk export service functions use read-only datastore
authzed · Sep 20, 2024 · 66ee7e2 · 66ee7e2
2 parents f813abe + 869c5cb
commit 66ee7e2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/services/v1/experimental.go b/internal/services/v1/experimental.go
@@ -295,7 +295,7 @@ func (es *experimentalServer) BulkExportRelationships(
 // BulkExport implements the BulkExportRelationships API functionality. Given a datastore.Datastore, it will
 // export stream via the sender all relationships matched by the incoming request.
 // If no cursor is provided, it will fallback to the provided revision.
-func BulkExport(ctx context.Context, ds datastore.Datastore, batchSize uint64, req *v1.BulkExportRelationshipsRequest, fallbackRevision datastore.Revision, sender func(response *v1.BulkExportRelationshipsResponse) error) error {
+func BulkExport(ctx context.Context, ds datastore.ReadOnlyDatastore, batchSize uint64, req *v1.BulkExportRelationshipsRequest, fallbackRevision datastore.Revision, sender func(response *v1.BulkExportRelationshipsResponse) error) error {
 	if req.OptionalLimit > 0 && uint64(req.OptionalLimit) > batchSize {
 		return shared.RewriteErrorWithoutConfig(ctx, NewExceedsMaximumLimitErr(uint64(req.OptionalLimit), batchSize))
 	}
@@ -752,7 +752,7 @@ func queryForEach(
 	return cur, nil
 }
 
-func decodeCursor(ds datastore.Datastore, encoded *v1.Cursor) (datastore.Revision, string, *core.RelationTuple, error) {
+func decodeCursor(ds datastore.ReadOnlyDatastore, encoded *v1.Cursor) (datastore.Revision, string, *core.RelationTuple, error) {
 	decoded, err := cursor.Decode(encoded)
 	if err != nil {
 		return datastore.NoRevision, "", nil, err

diff --git a/pkg/services/v1/services.go b/pkg/services/v1/services.go
@@ -12,6 +12,6 @@ import (
 // BulkExport implements the BulkExportRelationships API functionality. Given a datastore.Datastore, it will
 // export stream via the sender all relationships matched by the incoming request.
 // If no cursor is provided, it will fallback to the provided revision.
-func BulkExport(ctx context.Context, ds datastore.Datastore, batchSize uint64, req *v1.BulkExportRelationshipsRequest, fallbackRevision datastore.Revision, sender func(response *v1.BulkExportRelationshipsResponse) error) error {
+func BulkExport(ctx context.Context, ds datastore.ReadOnlyDatastore, batchSize uint64, req *v1.BulkExportRelationshipsRequest, fallbackRevision datastore.Revision, sender func(response *v1.BulkExportRelationshipsResponse) error) error {
 	return servicesv1.BulkExport(ctx, ds, batchSize, req, fallbackRevision, sender)
 }