Skip to content

Commit

Permalink
Hide a previously deprecated flag
Browse files Browse the repository at this point in the history
  • Loading branch information
josephschorr committed Feb 23, 2024
1 parent 395b96c commit 6ad3061
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions pkg/cmd/datastore/datastore.go
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,9 @@ func RegisterDatastoreFlagsWithPrefix(flagSet *pflag.FlagSet, prefix string, opt
return fmt.Errorf("failed to mark flag as deprecated: %w", err)
}

// TODO(jschorr): Remove this flag after a few versions.
flagSet.Uint16Var(&unusedSplitQueryCount, flagName("datastore-query-userset-batch-size"), 1024, "number of usersets after which a relationship query will be split into multiple queries")
if err := flagSet.MarkDeprecated(flagName("datastore-query-userset-batch-size"), "no longer has any effect"); err != nil {
return fmt.Errorf("failed to mark flag as deprecated: %w", err)
if err := flagSet.MarkHidden(flagName("datastore-query-userset-batch-size")); err != nil {
return fmt.Errorf("failed to mark flag as hidden: %w", err)
}

return nil
Expand Down

0 comments on commit 6ad3061

Please sign in to comment.