From 6ad30610706f22d3a8f5400adaa24f1d4d92d2bb Mon Sep 17 00:00:00 2001 From: Joseph Schorr Date: Fri, 23 Feb 2024 08:42:46 -0800 Subject: [PATCH] Hide a previously deprecated flag --- pkg/cmd/datastore/datastore.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/cmd/datastore/datastore.go b/pkg/cmd/datastore/datastore.go index e67e7eecc9..31b6a55db8 100644 --- a/pkg/cmd/datastore/datastore.go +++ b/pkg/cmd/datastore/datastore.go @@ -227,10 +227,9 @@ func RegisterDatastoreFlagsWithPrefix(flagSet *pflag.FlagSet, prefix string, opt return fmt.Errorf("failed to mark flag as deprecated: %w", err) } - // TODO(jschorr): Remove this flag after a few versions. flagSet.Uint16Var(&unusedSplitQueryCount, flagName("datastore-query-userset-batch-size"), 1024, "number of usersets after which a relationship query will be split into multiple queries") - if err := flagSet.MarkDeprecated(flagName("datastore-query-userset-batch-size"), "no longer has any effect"); err != nil { - return fmt.Errorf("failed to mark flag as deprecated: %w", err) + if err := flagSet.MarkHidden(flagName("datastore-query-userset-batch-size")); err != nil { + return fmt.Errorf("failed to mark flag as hidden: %w", err) } return nil