Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dependencies and some other small things to reflect bootstrap 5 #50

Merged
merged 2 commits into from
Mar 14, 2024
Merged

update dependencies and some other small things to reflect bootstrap 5 #50

merged 2 commits into from
Mar 14, 2024

Conversation

NikB0t
Copy link
Contributor

@NikB0t NikB0t commented Mar 8, 2024

No description provided.

SageV-add123
SageV-add123 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@SageV-add123 SageV-add123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I mean hey looks good to me. Probably not gonna be a drop-in on old projects but what's a fella to do?

@NikB0t NikB0t merged commit 7c6c2c3 into master Mar 14, 2024
@NikB0t
Copy link
Contributor Author

NikB0t commented Mar 14, 2024

Yeah, these changes are definitely not a drop-in for any of projects and it just magically works.
I plan on going one-by-one with them and making the appropriate changes. There might be another pr for this once I start testing on other products too to account for stuff I didn't catch from the testing I have done so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SageV-add123 SageV-add123 SageV-add123 approved these changes

@calebsoper calebsoper calebsoper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikB0t @calebsoper @SageV-add123