Revert state on error #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alemkin
approved these changes
Aug 6, 2018
frodare
suggested changes
Aug 7, 2018
src/containers/Pager.js
Outdated
| const nextPage = event.target.getAttribute('data-page') | ||
| props.refreshData(props.name, {...props.filter, page: nextPage}) | ||
| const currentPage = props.filter.page | ||
| const nextPage = parseInt(event.target.getAttribute('data-page')) |
There was a problem hiding this comment.
add radix:
parseInt(event.target.getAttribute('data-page'), 10)
src/reducer.js
Outdated
| filter: { | ||
| ...state.filter, | ||
| page: state.filter.nextPage || state.filter.page | ||
| }, |
There was a problem hiding this comment.
it looks like this was on the right path, but it doesn't look completed
added 3 commits
August 7, 2018 13:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #20
I tested this by throwing an error on example and it didn't update the pager number only updates the pager number when data is successfully set.