-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JOSS Review] Pipeline example not working #269
Comments
I fixed the example, many thanks. I'm surprised this was broken. Unfortunatly the README is the few places we can't automatically run code samples. The main documentation's code is tested in CI to ensure it runs correctly :) The issue was actually a stray The issue with dask was a bad import that came from the wrong place. I've fixed both in this PR so many thanks for finding these, hopefully you can copy and paste the example (with sklearn installed). As a side note, the |
Hi @eddiebergman , trying to run the example from #270 I now receive
|
Aye, that would need to be installed, as referenced in another issue, it's an entirely optional dependancy (but required with SMAC). One option would be The other option would be to use I guess the main issue that needs to be addressed here is including a comment or something that mentions what dependancies are needed for which example. |
Yes, works now with the deps :) |
The minimal example on pipelines is not working for me.
>>
in the example.sklearn
anddask
which you might want to mention in the description.config
seems to be undefined(opened as part of JOSS Review openjournals/joss-reviews#6367 )
The text was updated successfully, but these errors were encountered: