Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributors guide to explain the default settings for PR branch created from a fork #573

Open
3 tasks done
idorobotics opened this issue Jun 17, 2024 · 1 comment
Assignees
Labels
status:stale Inactive or outdated issues. (auto-assigned) type:good-first-issue Suitable for newcomers.

Comments

@idorobotics
Copy link

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

When a PR branch is created from a fork, Github gives the option to Allow edits and access to secrets by maintainers. This option is selected by default.

If a PR author deselects this option, merging can become a challenge since maintainers cannot make edits related to the fork. See, for example, autowarefoundation/autoware.universe#5748 and autowarefoundation/autoware.universe#5731

The contributors guidelines should explain why it is preferred to enable repository maintainer permissions.

Purpose

To streamline merging of PR branches created from forks.

Possible approaches

Update the contribution guideline to explain this.

Definition of done

Documentation updated.

@idorobotics idorobotics added the type:good-first-issue Suitable for newcomers. label Jun 17, 2024
@idorobotics idorobotics moved this to Foundation in Open AD Kit Working Group Jun 20, 2024
@idorobotics idorobotics moved this to Todo in Autoware Labs Jun 20, 2024
@oguzkaganozt oguzkaganozt moved this from Foundation to Execution in Open AD Kit Working Group Aug 1, 2024
@oguzkaganozt oguzkaganozt self-assigned this Aug 1, 2024
Copy link

stale bot commented Oct 1, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Oct 1, 2024
@xmfcx xmfcx removed this from Autoware Labs Oct 4, 2024
@oguzkaganozt oguzkaganozt moved this from Execution to Done in Open AD Kit Working Group Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale Inactive or outdated issues. (auto-assigned) type:good-first-issue Suitable for newcomers.
Projects
Status: Done
Status: Todo
Development

No branches or pull requests

2 participants