Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove the deprecated .cspell.json dict #4

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Nov 27, 2024

Description

We have .cspell and a deprecated cspell/.cspell file within the repository.

Almost every repository within the autoware folder is referring to the .cspell (for now from tier4 org):

mfc@whale:~/projects/autoware$ grep -r "main/.cspell.json" .
./src/vehicle/external/pacmod_interface/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/vehicle/awsim_labs_vehicle_launch/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/vehicle/sample_vehicle_launch/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/launcher/autoware_launch/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/sensor_component/external/sensor_component_description/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/sensor_component/external/nebula/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/core/autoware_lanelet2_extension/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/core/autoware_utils/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/core/autoware_internal_msgs/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/core/autoware_adapi_msgs/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/core/autoware_common/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/core/autoware_cmake/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/core/autoware.core/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/core/autoware_msgs/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/param/autoware_individual_params/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/sensor_kit/sample_sensor_kit_launch/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/sensor_kit/external/awsim_sensor_kit_launch/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/sensor_kit/awsim_labs_sensor_kit_launch/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/universe/external/tier4_autoware_msgs/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/universe/external/tier4_ad_api_adaptor/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/universe/autoware.universe/.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/universe/autoware.universe/.github/workflows/spell-check-daily.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/tools/.github/workflows/spell-check-all.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./src/tools/.github/workflows/spell-check-partial.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json
./.github/workflows/spell-check-differential.yaml:          cspell-json-url: https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/.cspell.json

The only exception:

mfc@whale:~/projects/autoware$ grep -r "cspell/.cspell.json" src/
src/universe/external/pointcloud_to_laserscan/.github/workflows/spell_check_pr.yml:            https://raw.githubusercontent.com/tier4/autoware-spell-check-dict/main/cspell/.cspell.json

This PR removes the deprecated file and the CI check that attempts to prevent changes to the deprecated file.

Related links

None.

Notes for reviewers

None.

@xmfcx xmfcx requested a review from mitsudome-r as a code owner November 27, 2024 14:37
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx self-assigned this Nov 27, 2024
@xmfcx
Copy link
Contributor Author

xmfcx commented Nov 27, 2024

Ready for review ✅

@mitsudome-r mitsudome-r merged commit 34425b6 into main Nov 28, 2024
7 checks passed
@mitsudome-r mitsudome-r deleted the feat/remove-old-dict branch November 28, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants