-
Notifications
You must be signed in to change notification settings - Fork 661
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci(cppcheck-all, cppcheck-differential): add cppcheck (#7262)
* ci: add cppcheck Signed-off-by: kminoda <[email protected]> * add more suppression Signed-off-by: kminoda <[email protected]> * update cppcheck version Signed-off-by: kminoda <[email protected]> * update suppressions list Signed-off-by: kminoda <[email protected]> * add two workflows Signed-off-by: kminoda <[email protected]> * change name Signed-off-by: kminoda <[email protected]> * change timing of all ci Signed-off-by: kminoda <[email protected]> * update Signed-off-by: kminoda <[email protected]> * update Signed-off-by: kminoda <[email protected]> * update Signed-off-by: kminoda <[email protected]> * fix Signed-off-by: kminoda <[email protected]> * update name Signed-off-by: kminoda <[email protected]> * fix mistake Signed-off-by: kminoda <[email protected]> * add echo in diff Signed-off-by: kminoda <[email protected]> * update regex Signed-off-by: kminoda <[email protected]> * add statistics for cppcheck-all Signed-off-by: kminoda <[email protected]> * avoid checking cppcheck dir Signed-off-by: kminoda <[email protected]> * error-exit Signed-off-by: kminoda <[email protected]> * dummy test Signed-off-by: kminoda <[email protected]> * upload file even if it fails Signed-off-by: kminoda <[email protected]> * fix bug Signed-off-by: kminoda <[email protected]> * revert unnecessary commit Signed-off-by: kminoda <[email protected]> * minor fix Signed-off-by: kminoda <[email protected]> * dummy test Signed-off-by: kminoda <[email protected]> * dummy test Signed-off-by: kminoda <[email protected]> * modify to show cppcheck result even when failure Signed-off-by: kminoda <[email protected]> * finalize PR Signed-off-by: kminoda <[email protected]> * fix pre-commit Signed-off-by: kminoda <[email protected]> * fix pre-commit Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: kminoda <[email protected]>
- Loading branch information
Showing
3 changed files
with
184 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
arrayIndexThenCheck | ||
assignBoolToFloat | ||
checkersReport | ||
constParameterPointer | ||
constParameterReference | ||
constStatement | ||
constVariable | ||
constVariablePointer | ||
constVariableReference | ||
containerOutOfBounds | ||
cstyleCast | ||
ctuOneDefinitionRuleViolation | ||
current_deleted_index | ||
duplicateAssignExpression | ||
duplicateBranch | ||
duplicateBreak | ||
duplicateCondition | ||
duplicateExpression | ||
funcArgNamesDifferent | ||
functionConst | ||
functionStatic | ||
invalidPointerCast | ||
knownConditionTrueFalse | ||
missingInclude | ||
missingIncludeSystem | ||
multiCondition | ||
noConstructor | ||
noExplicitConstructor | ||
noValidConfiguration | ||
obstacle_cruise_planner | ||
passedByValue | ||
preprocessorErrorDirective | ||
redundantAssignment | ||
redundantContinue | ||
redundantIfRemove | ||
redundantInitialization | ||
returnByReference | ||
selfAssignment | ||
shadowArgument | ||
shadowFunction | ||
shadowVariable | ||
stlFindInsert | ||
syntaxError | ||
uninitMemberVar | ||
unknownMacro | ||
unmatchedSuppression | ||
unpreciseMathCall | ||
unreadVariable | ||
unsignedLessThanZero | ||
unusedFunction | ||
unusedScopedObject | ||
unusedStructMember | ||
unusedVariable | ||
useInitializationList | ||
useStlAlgorithm | ||
uselessCallsSubstr | ||
uselessOverride | ||
variableScope | ||
virtualCallInConstructor |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
name: cppcheck-all | ||
|
||
on: | ||
pull_request: | ||
schedule: | ||
- cron: 0 0 * * * | ||
workflow_dispatch: | ||
|
||
jobs: | ||
cppcheck-all: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v2 | ||
|
||
- name: Install dependencies | ||
run: | | ||
sudo apt-get update | ||
sudo apt-get install -y build-essential cmake git libpcre3-dev | ||
# cppcheck from apt does not yet support --check-level args, and thus install from source | ||
- name: Install Cppcheck from source | ||
run: | | ||
mkdir /tmp/cppcheck | ||
git clone https://github.com/danmar/cppcheck.git /tmp/cppcheck | ||
cd /tmp/cppcheck | ||
git checkout 2.14.1 | ||
mkdir build | ||
cd build | ||
cmake .. | ||
make -j $(nproc) | ||
sudo make install | ||
- name: Run Cppcheck on all files | ||
continue-on-error: true | ||
id: cppcheck | ||
run: | | ||
cppcheck --enable=all --inconclusive --check-level=exhaustive --error-exitcode=1 --xml . 2> cppcheck-report.xml | ||
shell: bash | ||
|
||
- name: Count errors by error ID and severity | ||
run: | | ||
#!/bin/bash | ||
temp_file=$(mktemp) | ||
grep -oP '(?<=id=")[^"]+" severity="[^"]+' cppcheck-report.xml | sed 's/" severity="/,/g' > "$temp_file" | ||
echo "Error counts by error ID and severity:" | ||
sort "$temp_file" | uniq -c | ||
rm "$temp_file" | ||
shell: bash | ||
|
||
- name: Upload Cppcheck report | ||
uses: actions/upload-artifact@v2 | ||
with: | ||
name: cppcheck-report | ||
path: cppcheck-report.xml | ||
|
||
- name: Fail the job if Cppcheck failed | ||
if: steps.cppcheck.outcome == 'failure' | ||
run: exit 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
name: cppcheck-differential | ||
|
||
on: | ||
pull_request: | ||
|
||
jobs: | ||
cppcheck-differential: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v2 | ||
|
||
- name: Install dependencies | ||
run: | | ||
sudo apt-get update | ||
sudo apt-get install -y build-essential cmake git libpcre3-dev | ||
# cppcheck from apt does not yet support --check-level args, and thus install from source | ||
- name: Install Cppcheck from source | ||
run: | | ||
mkdir /tmp/cppcheck | ||
git clone https://github.com/danmar/cppcheck.git /tmp/cppcheck | ||
cd /tmp/cppcheck | ||
git checkout 2.14.1 | ||
mkdir build | ||
cd build | ||
cmake .. | ||
make -j $(nproc) | ||
sudo make install | ||
- name: Get changed files | ||
id: changed-files | ||
run: | | ||
git fetch origin ${{ github.base_ref }} --depth=1 | ||
git diff --name-only FETCH_HEAD ${{ github.sha }} > changed_files.txt | ||
cat changed_files.txt | ||
- name: Run Cppcheck on changed files | ||
continue-on-error: true | ||
id: cppcheck | ||
run: | | ||
files=$(cat changed_files.txt | grep -E '\.(cpp|hpp)$' || true) | ||
if [ -n "$files" ]; then | ||
echo "Running Cppcheck on changed files: $files" | ||
cppcheck --enable=all --inconclusive --check-level=exhaustive --error-exitcode=1 --suppressions-list=.cppcheck_suppressions $files 2> cppcheck-report.txt | ||
else | ||
echo "No C++ files changed." | ||
touch cppcheck-report.txt | ||
fi | ||
shell: bash | ||
|
||
- name: Show cppcheck-report result | ||
run: | | ||
cat cppcheck-report.txt | ||
- name: Upload Cppcheck report | ||
uses: actions/upload-artifact@v2 | ||
with: | ||
name: cppcheck-report | ||
path: cppcheck-report.txt | ||
|
||
- name: Fail the job if Cppcheck failed | ||
if: steps.cppcheck.outcome == 'failure' | ||
run: exit 1 |