From 4baa9e2867b203e048196b86ed00f06fb0470a09 Mon Sep 17 00:00:00 2001 From: ktro2828 Date: Wed, 11 Oct 2023 13:58:42 +0900 Subject: [PATCH] refactor: rename parameter to avoid failure of spell-check Signed-off-by: ktro2828 --- .../config/roi_sync.param.yaml | 12 ++++++------ .../schema/roi_sync.schema.json | 12 ++++++------ .../src/fusion_node.cpp | 12 ++++++------ 3 files changed, 18 insertions(+), 18 deletions(-) diff --git a/perception/image_projection_based_fusion/config/roi_sync.param.yaml b/perception/image_projection_based_fusion/config/roi_sync.param.yaml index f2e020344acb9..99d85089befb8 100644 --- a/perception/image_projection_based_fusion/config/roi_sync.param.yaml +++ b/perception/image_projection_based_fusion/config/roi_sync.param.yaml @@ -5,9 +5,9 @@ match_threshold_ms: 50.0 image_buffer_size: 15 debug_mode: false - filter_scope_minx: -100.0 - filter_scope_miny: -100.0 - filter_scope_minz: -100.0 - filter_scope_maxx: 100.0 - filter_scope_maxy: 100.0 - filter_scope_maxz: 100.0 + filter_scope_min_x: -100.0 + filter_scope_min_y: -100.0 + filter_scope_min_z: -100.0 + filter_scope_max_x: 100.0 + filter_scope_max_y: 100.0 + filter_scope_max_z: 100.0 diff --git a/perception/image_projection_based_fusion/schema/roi_sync.schema.json b/perception/image_projection_based_fusion/schema/roi_sync.schema.json index b6f2d46e18ebc..411fb678a49a7 100644 --- a/perception/image_projection_based_fusion/schema/roi_sync.schema.json +++ b/perception/image_projection_based_fusion/schema/roi_sync.schema.json @@ -36,32 +36,32 @@ "description": "Whether to debug or not.", "default": false }, - "filter_scope_minx": { + "filter_scope_min_x": { "type": "number", "description": "Minimum x position to be considered for debug [m].", "default": -100.0 }, - "filter_scope_miny": { + "filter_scope_min_y": { "type": "number", "description": "Minimum y position to be considered for debug [m].", "default": -100.0 }, - "filter_scope_minz": { + "filter_scope_min_z": { "type": "number", "description": "Minimum z position to be considered for debug [m].", "default": -100.0 }, - "filter_scope_maxx": { + "filter_scope_max_x": { "type": "number", "description": "Maximum x position to be considered for debug [m].", "default": 100.0 }, - "filter_scope_maxy": { + "filter_scope_max_y": { "type": "number", "description": "Maximum y position to be considered for debug [m].", "default": 100.0 }, - "filter_scope_maxz": { + "filter_scope_max_z": { "type": "number", "description": "Maximum z position [m].", "default": 100.0 diff --git a/perception/image_projection_based_fusion/src/fusion_node.cpp b/perception/image_projection_based_fusion/src/fusion_node.cpp index 78ce9fdb59d87..7994a3fa7b4d6 100644 --- a/perception/image_projection_based_fusion/src/fusion_node.cpp +++ b/perception/image_projection_based_fusion/src/fusion_node.cpp @@ -139,12 +139,12 @@ FusionNode::FusionNode( // cspell: ignore minx, maxx, miny, maxy, minz, maxz // FIXME: use min_x instead of minx - filter_scope_minx_ = declare_parameter("filter_scope_minx"); - filter_scope_maxx_ = declare_parameter("filter_scope_maxx"); - filter_scope_miny_ = declare_parameter("filter_scope_miny"); - filter_scope_maxy_ = declare_parameter("filter_scope_maxy"); - filter_scope_minz_ = declare_parameter("filter_scope_minz"); - filter_scope_maxz_ = declare_parameter("filter_scope_maxz"); + filter_scope_minx_ = declare_parameter("filter_scope_min_x"); + filter_scope_maxx_ = declare_parameter("filter_scope_max_x"); + filter_scope_miny_ = declare_parameter("filter_scope_min_y"); + filter_scope_maxy_ = declare_parameter("filter_scope_max_y"); + filter_scope_minz_ = declare_parameter("filter_scope_min_z"); + filter_scope_maxz_ = declare_parameter("filter_scope_max_z"); } template