Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ground remover package cannot delete ghost points appears front of car when passing speedbump #3673

Closed
3 tasks done
Zeysthingz opened this issue May 11, 2023 · 4 comments
Closed
3 tasks done
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned)

Comments

@Zeysthingz
Copy link
Contributor

Zeysthingz commented May 11, 2023

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

Currently we are using scan_ground_filter algorithm in ground segmentation node but when passing speed bumps the algorithm can not work efficiently because vehicle is shaken and can not delete all ground points ghost points occurs front of vehicle.Because of point occurs on the way obstacle stop planner stops the car. Here is an example of this problem:
jiraya2222

Default parameter values are below:

  global_slope_max_angle_deg: 10.0
  local_slope_max_angle_deg: 13.0 # recommended 30.0 for non elevation_grid_mode
  split_height_distance: 0.2
  non_ground_height_threshold: 0.20
  grid_mode_switch_radius: 20.0
  gnd_grid_buffer_size: 4
  detection_range_z_max: 2.5
  elevation_grid_mode: true

Mainly increasing non_ground_height_threshold parameter affects deleting these points and this parameter is height threshold of non ground objects for elevation grid mode.Currently we tuned parameters and took better result but when increase parameters to much we are losing points tuned_video.

Here is tuned parameters below:

    global_slope_max_angle_deg 50.0
    local_slope_max_angle_deg 35.0 
    split_height_distance 0.25
    non_ground_height_threshold 0.50
    grid_mode_switch_radius 30.0
    gnd_grid_buffer_size 1
    detection_range_z_max 2.5
    elevation_grid_mode true

Here is a bag file to help understand problem ground_remover_bag

Purpose

To improve algorithm when passing speed bumps

Possible approaches

improve algorithm

Definition of done

Tuned current algorithm and tested it on vehicle

@Zeysthingz Zeysthingz added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels May 11, 2023
@Zeysthingz
Copy link
Contributor Author

Zeysthingz commented Jun 2, 2023

Here is a bag file also includes localization topics.
bag_includes_imu
@miursh
@kaancolak

@stale
Copy link

stale bot commented Aug 12, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Aug 12, 2023
@amadeuszsz
Copy link
Contributor

@vividf friendly ping

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Jul 5, 2024
@vividf
Copy link
Contributor

vividf commented Jul 5, 2024

@vividf vividf closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned)
Projects
No open projects
Development

No branches or pull requests

3 participants