Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization issue while driving uphill #8069

Closed
3 tasks done
Kim-mins opened this issue Jul 17, 2024 · 6 comments
Closed
3 tasks done

Localization issue while driving uphill #8069

Kim-mins opened this issue Jul 17, 2024 · 6 comments
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) simulator:carla Issue related to CARLA simulator

Comments

@Kim-mins
Copy link
Contributor

Kim-mins commented Jul 17, 2024

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

Hi team,

I'm currently running Autoware with Carla using bridge implementation, and I found a situation that the localization gets bad while driving uphill, and it eventually makes the ego vehicle stop.

Here's the rviz video and launch.log file: [video] [launch.log]

At the start of the video, the poincloud matches with the given .pcd file, but it gets worse as the vehicle goes up, and the vehicle eventually stops and could not reach to the goal point.
Also, the trace(skyblue line) in rviz shows that there are oscillation on the baselink.

And according to the log file, there are logs that sayingNVTL gets worse.

...
1721137556.6314461 [ndt_scan_matcher_node-42] [WARN] [1721137556.630878637] [localization.pose_estimator.ndt_scan_matcher]: Score is below the threshold. Score: 2.23286, Threshold: 2.3
...
1721137561.2945189 [ndt_scan_matcher_node-42] [WARN] [1721137561.293876881] [localization.pose_estimator.ndt_scan_matcher]: Score is below the threshold. Score: 1.28923, Threshold: 2.3
...

Expected behavior

I hope the ego vehicle to drive to the destination well.

Actual behavior

But it could not reach to the given goal point.

Steps to reproduce

Here's the ros2bag file for the reproduction: [ros2bag]

Versions

Possible causes

No response

Additional context

No response

@Motsu-san Motsu-san added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Jul 17, 2024
@maxime-clem maxime-clem added the simulator:carla Issue related to CARLA simulator label Jul 17, 2024
@KYabuuchi
Copy link
Contributor

I checked your rosbag in my environment. I found your point cloud map is missing some buildings, which seems to be causing the scan matching to not work correctly.

Therefore, I believe this issue will be resolved if you fix the point cloud map.

@KYabuuchi
Copy link
Contributor

On the other hand, I have successfully prevented the scan matcher from failing on hills by adjusting the following parameters, without updating the map.

  • autoware_launch/config/localization/ekf_localizer.param.yaml
-      z_filter_proc_dev: 1.0
+      z_filter_proc_dev: 3.0
       roll_filter_proc_dev: 0.01
-      pitch_filter_proc_dev: 0.01
+      pitch_filter_proc_dev: 0.1
  • autoware_launch/config/localization/ndt_scan_matcher/pointcloud_preprocessor/crop_box_filter_measurement_range.param.yaml
-    min_x: -60.0
+    min_x: -30.0
     max_x: 60.0
-    min_y: -60.0
-    max_y: 60.0
+    min_y: -30.0
+    max_y: 30.0

This change is intended to cut off the point cloud and prevent the virtual building and hill from being observed simultaneously.

kimmins_carla_issue.mp4

It is still unstable but I think we can improve it more by adjusting the parameters.

@Kim-mins
Copy link
Contributor Author

Thank you for your detailed investigation @KYabuuchi!

I did not notice that my .pcd file misses some pointclouds. Thank you for pointing out.

I agree to your modification works well, but I got one small question for this issue.

  • Question: I think using the default parameters for ndt scan matcher is encouraged, and seems I should change the parameters if I want to resolve the issue. If I don't change the parameters, should I fill the missed part of the .pcd file?

I really appreciate to your help! Thanks!

@KYabuuchi
Copy link
Contributor

@Kim-mins
I don't think using the default parameters of the NDT scan matcher is necessarily encouraged. It's expected that parameters will be adjusted according to the environment.

If you don't change the parameters, you'll need to fix the pcd file. Alternatively, avoiding unmapped areas should prevent the issue from occurring.

@Kim-mins
Copy link
Contributor Author

Thank you for the clear answers @KYabuuchi!

Then it seems better for me to change the parameters.. Thanks a lot!

The issue seems gone now, so can I close this issue?

@KYabuuchi
Copy link
Contributor

@Kim-mins Yes. Please close this issue 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) simulator:carla Issue related to CARLA simulator
Projects
None yet
Development

No branches or pull requests

4 participants