Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Freespace Planner currently uses a detached ROS clock instead of a node clock when populating headers #9161

Closed
3 tasks done
stevenbrills opened this issue Oct 25, 2024 · 2 comments
Assignees
Labels
type:bug Software flaws or errors.

Comments

@stevenbrills
Copy link
Contributor

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

The freespace planner populates headers with a detached clock causing the output trajectories to use system time instead of sim time when the rest of the stack is using sim time. This causes downstream issues, particularly in the trajectory follower subsystem where the velocity buffer is cleared based on a time threshold which doesn't happen since the discrepancy between the system time and sim time prevents it from meeting the buffer clearance threshold.

Expected behavior

The output trajectory should reflect time from the source specified globally.

Actual behavior

The output trajectory from the freespace planner uses the incorrect clock to populate the header causing the downstream is_steering_converged flag in the trajectory follower from being satisfied.

Steps to reproduce

  1. Launch a simulator with a town which has a parking lot, the default Town05 in CARLA works well.
  2. Launch the Autoware stack and give a goal that takes the vehicle into the parking lot.
  3. Once the vehicle parks, give another goal that takes it back into the lane.

Versions

  • OS: Ubuntu 22.04
  • ROS2: Humble
  • Autoware: Main

Possible causes

Incorrect detached clock being used to populate the header in the trajectory.

Additional context

No response

@stevenbrills
Copy link
Contributor Author

fixes #9152

@idorobotics idorobotics added the type:bug Software flaws or errors. label Oct 30, 2024
@stevenbrills
Copy link
Contributor Author

Fixed in #9152.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Software flaws or errors.
Projects
None yet
Development

No branches or pull requests

2 participants