From a77ef63f879a33c761f6e8618cffb47d8101c48f Mon Sep 17 00:00:00 2001 From: Esteve Fernandez Date: Fri, 15 Mar 2024 16:12:51 +0100 Subject: [PATCH 01/14] build(behavior_velocity_template_module): prefix package and namespace with autoware_ Signed-off-by: Esteve Fernandez --- planning/behavior_velocity_template_module/CMakeLists.txt | 2 +- planning/behavior_velocity_template_module/package.xml | 2 +- planning/behavior_velocity_template_module/plugins.xml | 2 +- planning/behavior_velocity_template_module/src/manager.cpp | 5 ++++- planning/behavior_velocity_template_module/src/manager.hpp | 3 +++ planning/behavior_velocity_template_module/src/scene.cpp | 3 +++ planning/behavior_velocity_template_module/src/scene.hpp | 3 +++ 7 files changed, 16 insertions(+), 4 deletions(-) diff --git a/planning/behavior_velocity_template_module/CMakeLists.txt b/planning/behavior_velocity_template_module/CMakeLists.txt index 103a3d0a4ceb3..88e6167dd4433 100644 --- a/planning/behavior_velocity_template_module/CMakeLists.txt +++ b/planning/behavior_velocity_template_module/CMakeLists.txt @@ -1,5 +1,5 @@ cmake_minimum_required(VERSION 3.14) -project(behavior_velocity_template_module) +project(autoware_behavior_velocity_template_module) find_package(autoware_cmake REQUIRED) autoware_package() diff --git a/planning/behavior_velocity_template_module/package.xml b/planning/behavior_velocity_template_module/package.xml index 93a1cb4042e93..20f808ae514fc 100644 --- a/planning/behavior_velocity_template_module/package.xml +++ b/planning/behavior_velocity_template_module/package.xml @@ -1,7 +1,7 @@ - behavior_velocity_template_module + autoware_behavior_velocity_template_module 0.1.0 The behavior_velocity_template_module package diff --git a/planning/behavior_velocity_template_module/plugins.xml b/planning/behavior_velocity_template_module/plugins.xml index 3560c84e6a080..55d937260bf97 100644 --- a/planning/behavior_velocity_template_module/plugins.xml +++ b/planning/behavior_velocity_template_module/plugins.xml @@ -1,3 +1,3 @@ - + diff --git a/planning/behavior_velocity_template_module/src/manager.cpp b/planning/behavior_velocity_template_module/src/manager.cpp index 22763f44af7bf..9ba4271ec7b79 100644 --- a/planning/behavior_velocity_template_module/src/manager.cpp +++ b/planning/behavior_velocity_template_module/src/manager.cpp @@ -26,6 +26,8 @@ #include #include +namespace autoware +{ namespace behavior_velocity_planner { using tier4_autoware_utils::getOrDeclareParameter; @@ -57,7 +59,8 @@ TemplateModuleManager::getModuleExpiredFunction( } } // namespace behavior_velocity_planner +} // namespace autoware #include PLUGINLIB_EXPORT_CLASS( - behavior_velocity_planner::TemplateModulePlugin, behavior_velocity_planner::PluginInterface) + autoware::behavior_velocity_planner::TemplateModulePlugin, behavior_velocity_planner::PluginInterface) diff --git a/planning/behavior_velocity_template_module/src/manager.hpp b/planning/behavior_velocity_template_module/src/manager.hpp index ef4e1f00cae92..24c437d7c482a 100644 --- a/planning/behavior_velocity_template_module/src/manager.hpp +++ b/planning/behavior_velocity_template_module/src/manager.hpp @@ -27,6 +27,8 @@ #include #include +namespace autoware +{ namespace behavior_velocity_planner { /** @@ -89,5 +91,6 @@ class TemplateModulePlugin : public PluginWrapper }; } // namespace behavior_velocity_planner +} // namespace autoware #endif // MANAGER_HPP_ diff --git a/planning/behavior_velocity_template_module/src/scene.cpp b/planning/behavior_velocity_template_module/src/scene.cpp index 558f67b49817c..6c0e5218ceb29 100644 --- a/planning/behavior_velocity_template_module/src/scene.cpp +++ b/planning/behavior_velocity_template_module/src/scene.cpp @@ -21,6 +21,8 @@ #include +namespace autoware +{ namespace behavior_velocity_planner { @@ -50,3 +52,4 @@ bool TemplateModule::modifyPathVelocity( } } // namespace behavior_velocity_planner +} // namespace autoware \ No newline at end of file diff --git a/planning/behavior_velocity_template_module/src/scene.hpp b/planning/behavior_velocity_template_module/src/scene.hpp index fab0b23efb25f..99a00963d665d 100644 --- a/planning/behavior_velocity_template_module/src/scene.hpp +++ b/planning/behavior_velocity_template_module/src/scene.hpp @@ -21,6 +21,8 @@ #include #include +namespace autoware +{ namespace behavior_velocity_planner { using autoware_auto_planning_msgs::msg::PathWithLaneId; @@ -65,5 +67,6 @@ class TemplateModule : public SceneModuleInterface }; } // namespace behavior_velocity_planner +} // namespace autoware #endif // SCENE_HPP_ From 92102faee0c5796e9e49fd766493eee87eb929c8 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 15 Mar 2024 15:22:01 +0000 Subject: [PATCH 02/14] style(pre-commit): autofix Signed-off-by: Esteve Fernandez --- planning/behavior_velocity_template_module/src/manager.cpp | 3 ++- planning/behavior_velocity_template_module/src/scene.cpp | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/planning/behavior_velocity_template_module/src/manager.cpp b/planning/behavior_velocity_template_module/src/manager.cpp index 9ba4271ec7b79..bb6a58e31eb2c 100644 --- a/planning/behavior_velocity_template_module/src/manager.cpp +++ b/planning/behavior_velocity_template_module/src/manager.cpp @@ -63,4 +63,5 @@ TemplateModuleManager::getModuleExpiredFunction( #include PLUGINLIB_EXPORT_CLASS( - autoware::behavior_velocity_planner::TemplateModulePlugin, behavior_velocity_planner::PluginInterface) + autoware::behavior_velocity_planner::TemplateModulePlugin, + behavior_velocity_planner::PluginInterface) diff --git a/planning/behavior_velocity_template_module/src/scene.cpp b/planning/behavior_velocity_template_module/src/scene.cpp index 6c0e5218ceb29..df4054e4d0112 100644 --- a/planning/behavior_velocity_template_module/src/scene.cpp +++ b/planning/behavior_velocity_template_module/src/scene.cpp @@ -52,4 +52,4 @@ bool TemplateModule::modifyPathVelocity( } } // namespace behavior_velocity_planner -} // namespace autoware \ No newline at end of file +} // namespace autoware From 86cdbd40e7bbe355382615a468a6d51606ed14f2 Mon Sep 17 00:00:00 2001 From: Esteve Fernandez Date: Wed, 27 Mar 2024 15:23:00 +0100 Subject: [PATCH 03/14] build: fix namespace Signed-off-by: Esteve Fernandez --- planning/behavior_velocity_template_module/src/scene.cpp | 2 ++ planning/behavior_velocity_template_module/src/scene.hpp | 1 + 2 files changed, 3 insertions(+) diff --git a/planning/behavior_velocity_template_module/src/scene.cpp b/planning/behavior_velocity_template_module/src/scene.cpp index df4054e4d0112..ce78faad95c15 100644 --- a/planning/behavior_velocity_template_module/src/scene.cpp +++ b/planning/behavior_velocity_template_module/src/scene.cpp @@ -26,6 +26,8 @@ namespace autoware namespace behavior_velocity_planner { +using ::behavior_path_planner::StopReason; + TemplateModule::TemplateModule( const int64_t module_id, const rclcpp::Logger & logger, const rclcpp::Clock::SharedPtr clock) : SceneModuleInterface(module_id, logger, clock) diff --git a/planning/behavior_velocity_template_module/src/scene.hpp b/planning/behavior_velocity_template_module/src/scene.hpp index 99a00963d665d..70ce6fe8a5ebc 100644 --- a/planning/behavior_velocity_template_module/src/scene.hpp +++ b/planning/behavior_velocity_template_module/src/scene.hpp @@ -26,6 +26,7 @@ namespace autoware namespace behavior_velocity_planner { using autoware_auto_planning_msgs::msg::PathWithLaneId; +using ::behavior_path_planner::StopReason; class TemplateModule : public SceneModuleInterface { From 64ad7fcb7bdb48158b35dceb64954eb1039c9992 Mon Sep 17 00:00:00 2001 From: Esteve Fernandez Date: Tue, 9 Apr 2024 15:30:52 +0200 Subject: [PATCH 04/14] build(autoware_behavior_velocity_template_module): fix namespace Signed-off-by: Esteve Fernandez --- planning/behavior_velocity_template_module/src/manager.hpp | 4 ++-- planning/behavior_velocity_template_module/src/scene.cpp | 2 -- planning/behavior_velocity_template_module/src/scene.hpp | 5 +++-- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/planning/behavior_velocity_template_module/src/manager.hpp b/planning/behavior_velocity_template_module/src/manager.hpp index 24c437d7c482a..504d8babb3d2c 100644 --- a/planning/behavior_velocity_template_module/src/manager.hpp +++ b/planning/behavior_velocity_template_module/src/manager.hpp @@ -39,7 +39,7 @@ namespace behavior_velocity_planner * * @param node A reference to the ROS node. */ -class TemplateModuleManager : public SceneModuleManagerInterface +class TemplateModuleManager : public ::behavior_velocity_planner::SceneModuleManagerInterface { public: explicit TemplateModuleManager(rclcpp::Node & node); @@ -86,7 +86,7 @@ class TemplateModuleManager : public SceneModuleManagerInterface * The TemplateModulePlugin class is used to integrate the TemplateModuleManager into the Behavior * Velocity Planner. */ -class TemplateModulePlugin : public PluginWrapper +class TemplateModulePlugin : public ::behavior_velocity_planner::PluginWrapper { }; diff --git a/planning/behavior_velocity_template_module/src/scene.cpp b/planning/behavior_velocity_template_module/src/scene.cpp index ce78faad95c15..df4054e4d0112 100644 --- a/planning/behavior_velocity_template_module/src/scene.cpp +++ b/planning/behavior_velocity_template_module/src/scene.cpp @@ -26,8 +26,6 @@ namespace autoware namespace behavior_velocity_planner { -using ::behavior_path_planner::StopReason; - TemplateModule::TemplateModule( const int64_t module_id, const rclcpp::Logger & logger, const rclcpp::Clock::SharedPtr clock) : SceneModuleInterface(module_id, logger, clock) diff --git a/planning/behavior_velocity_template_module/src/scene.hpp b/planning/behavior_velocity_template_module/src/scene.hpp index 70ce6fe8a5ebc..69093b4c461b4 100644 --- a/planning/behavior_velocity_template_module/src/scene.hpp +++ b/planning/behavior_velocity_template_module/src/scene.hpp @@ -26,9 +26,10 @@ namespace autoware namespace behavior_velocity_planner { using autoware_auto_planning_msgs::msg::PathWithLaneId; -using ::behavior_path_planner::StopReason; +using ::behavior_velocity_planner::StopReason; +using ::behavior_velocity_planner::SceneModuleInterface; -class TemplateModule : public SceneModuleInterface +class TemplateModule : public ::behavior_velocity_planner::SceneModuleInterface { public: TemplateModule( From e7fb4515c00050dc4af3d96bace4b07d581039fc Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue, 9 Apr 2024 13:33:04 +0000 Subject: [PATCH 05/14] style(pre-commit): autofix Signed-off-by: Esteve Fernandez --- planning/behavior_velocity_template_module/src/manager.hpp | 3 ++- planning/behavior_velocity_template_module/src/scene.hpp | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/planning/behavior_velocity_template_module/src/manager.hpp b/planning/behavior_velocity_template_module/src/manager.hpp index 504d8babb3d2c..4f4ada89cbd8a 100644 --- a/planning/behavior_velocity_template_module/src/manager.hpp +++ b/planning/behavior_velocity_template_module/src/manager.hpp @@ -86,7 +86,8 @@ class TemplateModuleManager : public ::behavior_velocity_planner::SceneModuleMan * The TemplateModulePlugin class is used to integrate the TemplateModuleManager into the Behavior * Velocity Planner. */ -class TemplateModulePlugin : public ::behavior_velocity_planner::PluginWrapper +class TemplateModulePlugin +: public ::behavior_velocity_planner::PluginWrapper { }; diff --git a/planning/behavior_velocity_template_module/src/scene.hpp b/planning/behavior_velocity_template_module/src/scene.hpp index 69093b4c461b4..b85fcb4f1ab56 100644 --- a/planning/behavior_velocity_template_module/src/scene.hpp +++ b/planning/behavior_velocity_template_module/src/scene.hpp @@ -26,8 +26,8 @@ namespace autoware namespace behavior_velocity_planner { using autoware_auto_planning_msgs::msg::PathWithLaneId; -using ::behavior_velocity_planner::StopReason; using ::behavior_velocity_planner::SceneModuleInterface; +using ::behavior_velocity_planner::StopReason; class TemplateModule : public ::behavior_velocity_planner::SceneModuleInterface { From 11a4d3bb5fcc3cb40fb82cd1530e0616c0a6f730 Mon Sep 17 00:00:00 2001 From: Esteve Fernandez Date: Tue, 9 Apr 2024 16:54:16 +0200 Subject: [PATCH 06/14] fix(autoware_velocity_template_module): fix clang-tidy issues Signed-off-by: Esteve Fernandez --- .../behavior_velocity_template_module/src/manager.hpp | 2 +- planning/behavior_velocity_template_module/src/scene.cpp | 7 ++----- planning/behavior_velocity_template_module/src/scene.hpp | 9 +++------ 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/planning/behavior_velocity_template_module/src/manager.hpp b/planning/behavior_velocity_template_module/src/manager.hpp index 4f4ada89cbd8a..d28b12d32eefc 100644 --- a/planning/behavior_velocity_template_module/src/manager.hpp +++ b/planning/behavior_velocity_template_module/src/manager.hpp @@ -55,7 +55,7 @@ class TemplateModuleManager : public ::behavior_velocity_planner::SceneModuleMan const char * getModuleName() override { return "template"; } private: - double dummy_parameter{0.0}; + double dummy_parameter_{0.0}; /** * @brief Launch new modules based on the provided path. diff --git a/planning/behavior_velocity_template_module/src/scene.cpp b/planning/behavior_velocity_template_module/src/scene.cpp index df4054e4d0112..644e59e6b3011 100644 --- a/planning/behavior_velocity_template_module/src/scene.cpp +++ b/planning/behavior_velocity_template_module/src/scene.cpp @@ -21,9 +21,7 @@ #include -namespace autoware -{ -namespace behavior_velocity_planner +namespace autoware::behavior_velocity_planner { TemplateModule::TemplateModule( @@ -51,5 +49,4 @@ bool TemplateModule::modifyPathVelocity( return false; } -} // namespace behavior_velocity_planner -} // namespace autoware +} // namespace autoware::behavior_velocity_planner diff --git a/planning/behavior_velocity_template_module/src/scene.hpp b/planning/behavior_velocity_template_module/src/scene.hpp index b85fcb4f1ab56..e8c00efcb3ee1 100644 --- a/planning/behavior_velocity_template_module/src/scene.hpp +++ b/planning/behavior_velocity_template_module/src/scene.hpp @@ -21,15 +21,13 @@ #include #include -namespace autoware -{ -namespace behavior_velocity_planner +namespace autoware::behavior_velocity_planner { using autoware_auto_planning_msgs::msg::PathWithLaneId; using ::behavior_velocity_planner::SceneModuleInterface; using ::behavior_velocity_planner::StopReason; -class TemplateModule : public ::behavior_velocity_planner::SceneModuleInterface +class TemplateModule : public SceneModuleInterface { public: TemplateModule( @@ -68,7 +66,6 @@ class TemplateModule : public ::behavior_velocity_planner::SceneModuleInterface motion_utils::VirtualWalls createVirtualWalls() override; }; -} // namespace behavior_velocity_planner -} // namespace autoware +} // namespace autoware::behavior_velocity_planner #endif // SCENE_HPP_ From 1bf87db42ae6ee9267fe967d7997b2493cc6249b Mon Sep 17 00:00:00 2001 From: Esteve Fernandez Date: Wed, 10 Apr 2024 11:11:27 +0200 Subject: [PATCH 07/14] build(autoware_behavior_velocity_template_module): fix variable name Signed-off-by: Esteve Fernandez --- planning/behavior_velocity_template_module/README.md | 2 +- planning/behavior_velocity_template_module/src/manager.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/planning/behavior_velocity_template_module/README.md b/planning/behavior_velocity_template_module/README.md index 1995b3e040061..2cc3e6db8a555 100644 --- a/planning/behavior_velocity_template_module/README.md +++ b/planning/behavior_velocity_template_module/README.md @@ -41,7 +41,7 @@ The managing of your modules is defined in manager.hpp and manager.cpp. The mana #### Constructor `TemplateModuleManager` - This is the constructor of the `TemplateModuleManager` class, and it takes an `rclcpp::Node` reference as a parameter. -- It initializes a member variable `dummy_parameter` to 0.0. +- It initializes a member variable `dummy_parameter_` to 0.0. #### `getModuleName()` Method diff --git a/planning/behavior_velocity_template_module/src/manager.cpp b/planning/behavior_velocity_template_module/src/manager.cpp index bb6a58e31eb2c..24e6997037be4 100644 --- a/planning/behavior_velocity_template_module/src/manager.cpp +++ b/planning/behavior_velocity_template_module/src/manager.cpp @@ -36,7 +36,7 @@ TemplateModuleManager::TemplateModuleManager(rclcpp::Node & node) : SceneModuleManagerInterface(node, getModuleName()) { std::string ns(getModuleName()); - dummy_parameter = getOrDeclareParameter(node, ns + ".dummy"); + dummy_parameter_ = getOrDeclareParameter(node, ns + ".dummy"); } void TemplateModuleManager::launchNewModules( From e55d19b32f136929952354bc85d3328b22ab22c1 Mon Sep 17 00:00:00 2001 From: Esteve Fernandez Date: Wed, 10 Apr 2024 13:00:08 +0200 Subject: [PATCH 08/14] fix(autoware_behavior_velocity_template_module): fix clang-tidy issues Signed-off-by: Esteve Fernandez --- planning/behavior_velocity_template_module/src/manager.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/planning/behavior_velocity_template_module/src/manager.cpp b/planning/behavior_velocity_template_module/src/manager.cpp index 24e6997037be4..48271e3487f8c 100644 --- a/planning/behavior_velocity_template_module/src/manager.cpp +++ b/planning/behavior_velocity_template_module/src/manager.cpp @@ -26,9 +26,7 @@ #include #include -namespace autoware -{ -namespace behavior_velocity_planner +namespace autoware::behavior_velocity_planner { using tier4_autoware_utils::getOrDeclareParameter; @@ -58,7 +56,6 @@ TemplateModuleManager::getModuleExpiredFunction( }; } -} // namespace behavior_velocity_planner } // namespace autoware #include From 33c252cf2be9467539e5da3686716c181a5bec3d Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed, 10 Apr 2024 11:02:20 +0000 Subject: [PATCH 09/14] style(pre-commit): autofix Signed-off-by: Esteve Fernandez --- planning/behavior_velocity_template_module/src/manager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/planning/behavior_velocity_template_module/src/manager.cpp b/planning/behavior_velocity_template_module/src/manager.cpp index 48271e3487f8c..c5861d032dee1 100644 --- a/planning/behavior_velocity_template_module/src/manager.cpp +++ b/planning/behavior_velocity_template_module/src/manager.cpp @@ -56,7 +56,7 @@ TemplateModuleManager::getModuleExpiredFunction( }; } -} // namespace autoware +} // namespace autoware::behavior_velocity_planner #include PLUGINLIB_EXPORT_CLASS( From 52edd6b6fac8d03943f5caf175c709d0e77a8c99 Mon Sep 17 00:00:00 2001 From: Esteve Fernandez Date: Wed, 10 Apr 2024 13:49:35 +0200 Subject: [PATCH 10/14] fix(autoware_behavior_velocity_template_module): fix tests Signed-off-by: Esteve Fernandez --- planning/behavior_velocity_template_module/src/manager.hpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/planning/behavior_velocity_template_module/src/manager.hpp b/planning/behavior_velocity_template_module/src/manager.hpp index d28b12d32eefc..aaaf0710eff46 100644 --- a/planning/behavior_velocity_template_module/src/manager.hpp +++ b/planning/behavior_velocity_template_module/src/manager.hpp @@ -27,9 +27,7 @@ #include #include -namespace autoware -{ -namespace behavior_velocity_planner +namespace autoware::behavior_velocity_planner { /** * @brief Constructor for the TemplateModuleManager class. @@ -91,7 +89,6 @@ class TemplateModulePlugin { }; -} // namespace behavior_velocity_planner -} // namespace autoware +} // namespace autoware::behavior_velocity_planner #endif // MANAGER_HPP_ From 9792cd9da1b74deff543b8b9983f36a760e4cd7e Mon Sep 17 00:00:00 2001 From: Esteve Fernandez Date: Wed, 24 Apr 2024 17:22:15 +0200 Subject: [PATCH 11/14] fix: missing renames Signed-off-by: Esteve Fernandez --- planning/behavior_velocity_template_module/package.xml | 2 +- planning/behavior_velocity_template_module/plugins.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/planning/behavior_velocity_template_module/package.xml b/planning/behavior_velocity_template_module/package.xml index 20f808ae514fc..fa3b20f5b5af8 100644 --- a/planning/behavior_velocity_template_module/package.xml +++ b/planning/behavior_velocity_template_module/package.xml @@ -3,7 +3,7 @@ autoware_behavior_velocity_template_module 0.1.0 - The behavior_velocity_template_module package + The autoware_behavior_velocity_template_module package Daniel Sanchez diff --git a/planning/behavior_velocity_template_module/plugins.xml b/planning/behavior_velocity_template_module/plugins.xml index 55d937260bf97..54aa67a9228bc 100644 --- a/planning/behavior_velocity_template_module/plugins.xml +++ b/planning/behavior_velocity_template_module/plugins.xml @@ -1,3 +1,3 @@ - + From ce79e544d9b73a79bee091b9b53640380ed569fc Mon Sep 17 00:00:00 2001 From: Esteve Fernandez Date: Thu, 9 May 2024 15:17:49 +0200 Subject: [PATCH 12/14] build(autoware_behavior_velocity_template_module): prefix base folder with autoware_ Signed-off-by: Esteve Fernandez --- .../CMakeLists.txt | 0 .../README.md | 0 .../config/template.param.yaml | 0 .../package.xml | 0 .../plugins.xml | 0 .../src/manager.cpp | 0 .../src/manager.hpp | 0 .../src/scene.cpp | 0 .../src/scene.hpp | 0 9 files changed, 0 insertions(+), 0 deletions(-) rename planning/{behavior_velocity_template_module => autoware_behavior_velocity_template_module}/CMakeLists.txt (100%) rename planning/{behavior_velocity_template_module => autoware_behavior_velocity_template_module}/README.md (100%) rename planning/{behavior_velocity_template_module => autoware_behavior_velocity_template_module}/config/template.param.yaml (100%) rename planning/{behavior_velocity_template_module => autoware_behavior_velocity_template_module}/package.xml (100%) rename planning/{behavior_velocity_template_module => autoware_behavior_velocity_template_module}/plugins.xml (100%) rename planning/{behavior_velocity_template_module => autoware_behavior_velocity_template_module}/src/manager.cpp (100%) rename planning/{behavior_velocity_template_module => autoware_behavior_velocity_template_module}/src/manager.hpp (100%) rename planning/{behavior_velocity_template_module => autoware_behavior_velocity_template_module}/src/scene.cpp (100%) rename planning/{behavior_velocity_template_module => autoware_behavior_velocity_template_module}/src/scene.hpp (100%) diff --git a/planning/behavior_velocity_template_module/CMakeLists.txt b/planning/autoware_behavior_velocity_template_module/CMakeLists.txt similarity index 100% rename from planning/behavior_velocity_template_module/CMakeLists.txt rename to planning/autoware_behavior_velocity_template_module/CMakeLists.txt diff --git a/planning/behavior_velocity_template_module/README.md b/planning/autoware_behavior_velocity_template_module/README.md similarity index 100% rename from planning/behavior_velocity_template_module/README.md rename to planning/autoware_behavior_velocity_template_module/README.md diff --git a/planning/behavior_velocity_template_module/config/template.param.yaml b/planning/autoware_behavior_velocity_template_module/config/template.param.yaml similarity index 100% rename from planning/behavior_velocity_template_module/config/template.param.yaml rename to planning/autoware_behavior_velocity_template_module/config/template.param.yaml diff --git a/planning/behavior_velocity_template_module/package.xml b/planning/autoware_behavior_velocity_template_module/package.xml similarity index 100% rename from planning/behavior_velocity_template_module/package.xml rename to planning/autoware_behavior_velocity_template_module/package.xml diff --git a/planning/behavior_velocity_template_module/plugins.xml b/planning/autoware_behavior_velocity_template_module/plugins.xml similarity index 100% rename from planning/behavior_velocity_template_module/plugins.xml rename to planning/autoware_behavior_velocity_template_module/plugins.xml diff --git a/planning/behavior_velocity_template_module/src/manager.cpp b/planning/autoware_behavior_velocity_template_module/src/manager.cpp similarity index 100% rename from planning/behavior_velocity_template_module/src/manager.cpp rename to planning/autoware_behavior_velocity_template_module/src/manager.cpp diff --git a/planning/behavior_velocity_template_module/src/manager.hpp b/planning/autoware_behavior_velocity_template_module/src/manager.hpp similarity index 100% rename from planning/behavior_velocity_template_module/src/manager.hpp rename to planning/autoware_behavior_velocity_template_module/src/manager.hpp diff --git a/planning/behavior_velocity_template_module/src/scene.cpp b/planning/autoware_behavior_velocity_template_module/src/scene.cpp similarity index 100% rename from planning/behavior_velocity_template_module/src/scene.cpp rename to planning/autoware_behavior_velocity_template_module/src/scene.cpp diff --git a/planning/behavior_velocity_template_module/src/scene.hpp b/planning/autoware_behavior_velocity_template_module/src/scene.hpp similarity index 100% rename from planning/behavior_velocity_template_module/src/scene.hpp rename to planning/autoware_behavior_velocity_template_module/src/scene.hpp From dc2c6c0153949c40a83ae1a7cf27f39d0953b38c Mon Sep 17 00:00:00 2001 From: Esteve Fernandez Date: Mon, 13 May 2024 16:10:17 +0200 Subject: [PATCH 13/14] fix: added prefix to missing strings Signed-off-by: Esteve Fernandez --- .github/CODEOWNERS | 2 +- planning/.pages | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 5f5d5008c0f1c..9af5404a359a0 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -148,6 +148,7 @@ perception/traffic_light_occlusion_predictor/** shunsuke.miura@tier4.jp tao.zhon perception/traffic_light_visualization/** tao.zhong@tier4.jp yukihiro.saito@tier4.jp planning/autoware_behavior_path_external_request_lane_change_module/** fumiya.watanabe@tier4.jp kosuke.takeuchi@tier4.jp shumpei.wakabayashi@tier4.jp tomohito.ando@tier4.jp tomoya.kimura@tier4.jp zulfaqar.azmi@tier4.jp planning/autoware_behavior_velocity_planner/** kosuke.takeuchi@tier4.jp kyoichi.sugahara@tier4.jp makoto.kurihara@tier4.jp mamoru.sobue@tier4.jp maxime.clement@tier4.jp satoshi.ota@tier4.jp shumpei.wakabayashi@tier4.jp taiki.tanaka@tier4.jp takayuki.murooka@tier4.jp tomohito.ando@tier4.jp tomoya.kimura@tier4.jp +planning/autoware_behavior_velocity_template_module/** daniel.sanchez@tier4.jp planning/autoware_planning_test_manager/** kyoichi.sugahara@tier4.jp takamasa.horibe@tier4.jp planning/autoware_remaining_distance_time_calculator/** ahmed.ebrahim@leodrive.ai planning/autoware_static_centerline_generator/** kosuke.takeuchi@tier4.jp takayuki.murooka@tier4.jp @@ -174,7 +175,6 @@ planning/behavior_velocity_planner_common/** fumiya.watanabe@tier4.jp isamu.taka planning/behavior_velocity_run_out_module/** kosuke.takeuchi@tier4.jp makoto.kurihara@tier4.jp shumpei.wakabayashi@tier4.jp takayuki.murooka@tier4.jp tomohito.ando@tier4.jp tomoya.kimura@tier4.jp planning/behavior_velocity_speed_bump_module/** mdogru@leodrive.ai shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp planning/behavior_velocity_stop_line_module/** fumiya.watanabe@tier4.jp shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp zhe.shen@tier4.jp -planning/behavior_velocity_template_module/** daniel.sanchez@tier4.jp planning/behavior_velocity_traffic_light_module/** mamoru.sobue@tier4.jp satoshi.ota@tier4.jp shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp planning/behavior_velocity_virtual_traffic_light_module/** kosuke.takeuchi@tier4.jp shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp planning/behavior_velocity_walkway_module/** satoshi.ota@tier4.jp shumpei.wakabayashi@tier4.jp takayuki.murooka@tier4.jp tomoya.kimura@tier4.jp diff --git a/planning/.pages b/planning/.pages index e355639eb8da5..574cc182cf424 100644 --- a/planning/.pages +++ b/planning/.pages @@ -19,7 +19,7 @@ nav: - 'Start Planner': planning/behavior_path_start_planner_module - 'Behavior Velocity Planner': - 'About Behavior Velocity': planning/autoware_behavior_velocity_planner - - 'Template for Custom Module': planning/behavior_velocity_template_module + - 'Template for Custom Module': planning/autoware_behavior_velocity_template_module - 'Available Module': - 'Blind Spot': planning/behavior_velocity_blind_spot_module - 'Crosswalk': planning/behavior_velocity_crosswalk_module From b08a173c869bf0f39f1a649a5fe29c4553572b08 Mon Sep 17 00:00:00 2001 From: Esteve Fernandez Date: Thu, 23 May 2024 13:03:03 +0200 Subject: [PATCH 14/14] refactor: update commented out dependency Signed-off-by: Esteve Fernandez --- planning/autoware_behavior_velocity_planner/package.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/planning/autoware_behavior_velocity_planner/package.xml b/planning/autoware_behavior_velocity_planner/package.xml index 573d862f1725b..c97a83fbff644 100644 --- a/planning/autoware_behavior_velocity_planner/package.xml +++ b/planning/autoware_behavior_velocity_planner/package.xml @@ -80,7 +80,7 @@ behavior_velocity_traffic_light_module behavior_velocity_virtual_traffic_light_module behavior_velocity_walkway_module - + rosidl_interface_packages