From 86e2b66f447588f1fd9df260cafaa693ea33f53f Mon Sep 17 00:00:00 2001 From: Ryohsuke Mitsudome Date: Wed, 25 Dec 2024 04:35:07 +0900 Subject: [PATCH 01/15] Revert "ci(build-test-tidy): introduce success condition jobs (#9769)" This reverts commit 421ec7d67b5624720d8dc33aa1fba04c6c5a06ef. --- .../actions/evaluate-job-result/action.yaml | 45 -------------- .github/workflows/build-test-tidy-pr.yaml | 61 ------------------- 2 files changed, 106 deletions(-) delete mode 100644 .github/actions/evaluate-job-result/action.yaml diff --git a/.github/actions/evaluate-job-result/action.yaml b/.github/actions/evaluate-job-result/action.yaml deleted file mode 100644 index c5c013080fd27..0000000000000 --- a/.github/actions/evaluate-job-result/action.yaml +++ /dev/null @@ -1,45 +0,0 @@ -name: Evaluate Job Result -description: Evaluates the result of a job and updates the summary. -inputs: - job_result: - description: Result of the job to evaluate (e.g., success, failure, skipped) - required: true - type: string - job_name: - description: Name of the job to evaluate - required: true - type: string - expected_results: - description: Comma-separated list of acceptable results (e.g., success,skipped) - required: true - type: string -outputs: - failed: - description: Indicates if the job failed - value: ${{ steps.evaluate.outputs.failed }} - -runs: - using: composite - steps: - - name: Evaluate Job Result - id: evaluate - run: | - JOB_RESULT="${{ inputs.job_result }}" - IFS=',' read -ra EXPECTED <<< "${{ inputs.expected_results }}" - FAILED=false - - for RESULT in "${EXPECTED[@]}"; do - if [[ "$JOB_RESULT" == "$RESULT" ]]; then - echo "- **${{ inputs.job_name }}:** "$JOB_RESULT" ✅" >> "$GITHUB_STEP_SUMMARY" - echo "failed=false" >> "$GITHUB_OUTPUT" - exit 0 - fi - done - - # If no expected result matched - echo "::error::${{ inputs.job_name }} failed. ❌" - echo "- **${{ inputs.job_name }}:** failed ❌" >> "$GITHUB_STEP_SUMMARY" - echo "failed=true" >> "$GITHUB_OUTPUT" - - exit 1 - shell: bash diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index d1ea9b2d0f79d..df2eff132eb05 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -58,34 +58,6 @@ jobs: secrets: codecov-token: ${{ secrets.CODECOV_TOKEN }} - build-test-pr: - needs: - - build-and-test-differential - - build-and-test-differential-cuda - if: ${{ always() }} - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - - name: Initialize Summary - run: echo "### Build Test PR Results" > $GITHUB_STEP_SUMMARY - shell: bash - - - name: Evaluate build-and-test-differential - uses: ./.github/actions/evaluate-job-result - with: - job_result: ${{ needs.build-and-test-differential.result }} - job_name: build-and-test-differential - expected_results: success - - - name: Evaluate build-and-test-differential-cuda - if: ${{ always() }} - uses: ./.github/actions/evaluate-job-result - with: - job_result: ${{ needs.build-and-test-differential-cuda.result }} - job_name: build-and-test-differential-cuda - expected_results: success,skipped - clang-tidy-differential: needs: - check-if-cuda-job-is-needed @@ -102,36 +74,3 @@ jobs: with: container: ghcr.io/autowarefoundation/autoware:universe-devel container-suffix: -cuda - - clang-tidy-pr: - needs: - - clang-tidy-differential - - clang-tidy-differential-cuda - if: ${{ always() }} - runs-on: ubuntu-latest - steps: - - name: Initialize Summary - run: echo "### Clang Tidy PR Results" > $GITHUB_STEP_SUMMARY - shell: bash - - - name: Check clang-tidy success - if: ${{ needs.clang-tidy-differential.result == 'success' || needs.clang-tidy-differential-cuda.result == 'success' }} - run: | - echo "✅ Either one of the following has succeeded:" >> $GITHUB_STEP_SUMMARY - - - name: Fail if conditions not met - if: ${{ !(needs.clang-tidy-differential.result == 'success' || needs.clang-tidy-differential-cuda.result == 'success') }} - run: | - echo "::error::❌ Either one of the following should have succeeded:" - echo "::error::clang-tidy-differential: ${{ needs.clang-tidy-differential.result }}" - echo "::error::clang-tidy-differential-cuda: ${{ needs.clang-tidy-differential-cuda.result }}" - - echo "❌ Either one of the following should have succeeded:" >> $GITHUB_STEP_SUMMARY - - exit 1 - - - name: Print the results - if: ${{ always() }} - run: | - echo "- **clang-tidy-differential:** ${{ needs.clang-tidy-differential.result }}" >> $GITHUB_STEP_SUMMARY - echo "- **clang-tidy-differential-cuda:** ${{ needs.clang-tidy-differential-cuda.result }}" >> $GITHUB_STEP_SUMMARY From dec0761da4f89baa74078d32686495f42efa6eb3 Mon Sep 17 00:00:00 2001 From: Ryohsuke Mitsudome Date: Wed, 25 Dec 2024 04:46:31 +0900 Subject: [PATCH 02/15] ci: pass run condition to reusable workflow Signed-off-by: Ryohsuke Mitsudome --- .github/workflows/build-and-test-differential.yaml | 5 +++++ .github/workflows/build-test-tidy-pr.yaml | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-and-test-differential.yaml b/.github/workflows/build-and-test-differential.yaml index 0925cb0f53930..c25f6b24c5e47 100644 --- a/.github/workflows/build-and-test-differential.yaml +++ b/.github/workflows/build-and-test-differential.yaml @@ -14,6 +14,10 @@ on: default: humble required: false type: string + run-condition: + default: true + required: false + type: boolean container-suffix: required: false default: "" @@ -28,6 +32,7 @@ env: jobs: build-and-test-differential: + if: ${{ inputs.run-condition }} runs-on: ${{ inputs.runner }} container: ${{ inputs.container }}${{ inputs.container-suffix }} steps: diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index df2eff132eb05..db1c0a2bb2b07 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -50,11 +50,11 @@ jobs: build-and-test-differential-cuda: needs: check-if-cuda-job-is-needed - if: ${{ needs.check-if-cuda-job-is-needed.outputs.cuda_job_is_needed == 'true' }} uses: ./.github/workflows/build-and-test-differential.yaml with: container: ghcr.io/autowarefoundation/autoware:universe-devel container-suffix: -cuda + run-condition: ${{ needs.check-if-cuda-job-is-needed.outputs.cuda_job_is_needed == 'true' }} secrets: codecov-token: ${{ secrets.CODECOV_TOKEN }} From 4c9f54fc73b8d4cb0f8e51591661e7ca01eb7bcd Mon Sep 17 00:00:00 2001 From: Ryohsuke Mitsudome Date: Wed, 25 Dec 2024 07:49:07 +0900 Subject: [PATCH 03/15] ci: add run-condition to clang-tidy-differential Signed-off-by: Ryohsuke Mitsudome --- .github/workflows/build-test-tidy-pr.yaml | 2 +- .github/workflows/clang-tidy-differential.yaml | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index db1c0a2bb2b07..8584fb10ee5b7 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -62,10 +62,10 @@ jobs: needs: - check-if-cuda-job-is-needed - build-and-test-differential - if: ${{ needs.check-if-cuda-job-is-needed.outputs.cuda_job_is_needed == 'false' }} uses: ./.github/workflows/clang-tidy-differential.yaml with: container: ghcr.io/autowarefoundation/autoware:universe-devel + run-condition: ${{ needs.check-if-cuda-job-is-needed.outputs.cuda_job_is_needed == 'false' }} clang-tidy-differential-cuda: needs: diff --git a/.github/workflows/clang-tidy-differential.yaml b/.github/workflows/clang-tidy-differential.yaml index 51e0a8408468c..41d722c8e07b0 100644 --- a/.github/workflows/clang-tidy-differential.yaml +++ b/.github/workflows/clang-tidy-differential.yaml @@ -14,9 +14,14 @@ on: default: ubuntu-24.04 required: false type: string + run-condition: + default: true + required: false + type: boolean jobs: clang-tidy-differential: + if: ${{ inputs.run-condition }} runs-on: ${{ inputs.runner }} container: ${{ inputs.container }}${{ inputs.container-suffix }} steps: From 92f1f2c20ab2bfa621c19c7b2f53e318ff835bd1 Mon Sep 17 00:00:00 2001 From: Ryohsuke Mitsudome Date: Wed, 25 Dec 2024 08:17:20 +0900 Subject: [PATCH 04/15] ci: always run parent job for clang-tidy for status report Signed-off-by: Ryohsuke Mitsudome --- .github/workflows/build-test-tidy-pr.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index 8584fb10ee5b7..47552e38d2bb8 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -59,6 +59,7 @@ jobs: codecov-token: ${{ secrets.CODECOV_TOKEN }} clang-tidy-differential: + if: ${{ always() }} needs: - check-if-cuda-job-is-needed - build-and-test-differential @@ -68,9 +69,11 @@ jobs: run-condition: ${{ needs.check-if-cuda-job-is-needed.outputs.cuda_job_is_needed == 'false' }} clang-tidy-differential-cuda: + if: ${{ always() }} needs: - build-and-test-differential-cuda uses: ./.github/workflows/clang-tidy-differential.yaml with: container: ghcr.io/autowarefoundation/autoware:universe-devel container-suffix: -cuda + run-condition: ${{ needs.check-if-cuda-job-is-needed.outputs.cuda_job_is_needed == 'true' }} From b6c0d6899c73e0580f8aab95a147bf28f1c34744 Mon Sep 17 00:00:00 2001 From: Ryohsuke Mitsudome Date: Wed, 25 Dec 2024 08:43:44 +0900 Subject: [PATCH 05/15] fix: add comment Signed-off-by: Ryohsuke Mitsudome --- .github/workflows/build-test-tidy-pr.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index 47552e38d2bb8..b57ec833d9ab8 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -59,7 +59,7 @@ jobs: codecov-token: ${{ secrets.CODECOV_TOKEN }} clang-tidy-differential: - if: ${{ always() }} + if: ${{ always() }} # always run to provide report for status check needs: - check-if-cuda-job-is-needed - build-and-test-differential @@ -69,7 +69,7 @@ jobs: run-condition: ${{ needs.check-if-cuda-job-is-needed.outputs.cuda_job_is_needed == 'false' }} clang-tidy-differential-cuda: - if: ${{ always() }} + if: ${{ always() }} # always run to provide report for status check needs: - build-and-test-differential-cuda uses: ./.github/workflows/clang-tidy-differential.yaml From 87e511eccb74b1a419675f2f6a8705bf20c5af6f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Mon, 30 Dec 2024 15:35:23 +0300 Subject: [PATCH 06/15] add missing job dependency MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .github/workflows/build-test-tidy-pr.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index b57ec833d9ab8..58306c17ac1d1 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -71,6 +71,7 @@ jobs: clang-tidy-differential-cuda: if: ${{ always() }} # always run to provide report for status check needs: + - check-if-cuda-job-is-needed - build-and-test-differential-cuda uses: ./.github/workflows/clang-tidy-differential.yaml with: From c627eb0171f7ea38b947143a089e06cfd9eaef08 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Mon, 30 Dec 2024 17:25:55 +0300 Subject: [PATCH 07/15] add condition to clang-tidy MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .github/workflows/build-test-tidy-pr.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index 58306c17ac1d1..e24d67cdc18de 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -66,7 +66,7 @@ jobs: uses: ./.github/workflows/clang-tidy-differential.yaml with: container: ghcr.io/autowarefoundation/autoware:universe-devel - run-condition: ${{ needs.check-if-cuda-job-is-needed.outputs.cuda_job_is_needed == 'false' }} + run-condition: ${{ needs.check-if-cuda-job-is-needed.outputs.cuda_job_is_needed == 'false' && needs.build-and-test-differential.result == 'success' }} clang-tidy-differential-cuda: if: ${{ always() }} # always run to provide report for status check @@ -77,4 +77,4 @@ jobs: with: container: ghcr.io/autowarefoundation/autoware:universe-devel container-suffix: -cuda - run-condition: ${{ needs.check-if-cuda-job-is-needed.outputs.cuda_job_is_needed == 'true' }} + run-condition: ${{ needs.check-if-cuda-job-is-needed.outputs.cuda_job_is_needed == 'true' && needs.build-and-test-differential-cuda.result == 'success' }} From 49394beb047101ea2774263bdf6f88002406972f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Mon, 30 Dec 2024 18:25:52 +0300 Subject: [PATCH 08/15] add if always to bnt-diff jobs too MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .github/workflows/build-test-tidy-pr.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index e24d67cdc18de..c0442694b5c77 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -40,15 +40,18 @@ jobs: shell: bash build-and-test-differential: + if: ${{ always() }} needs: - require-label uses: ./.github/workflows/build-and-test-differential.yaml with: container: ghcr.io/autowarefoundation/autoware:universe-devel + run-condition: ${{ needs.require-label.outputs.result == 'true' }} secrets: codecov-token: ${{ secrets.CODECOV_TOKEN }} build-and-test-differential-cuda: + if: ${{ always() }} needs: check-if-cuda-job-is-needed uses: ./.github/workflows/build-and-test-differential.yaml with: From c7b932fdababc51705e54397857c93632c5e9938 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Mon, 30 Dec 2024 18:50:12 +0300 Subject: [PATCH 09/15] use the fixed require-label branch MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .github/workflows/build-test-tidy-pr.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index c0442694b5c77..12685d491b405 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -14,7 +14,7 @@ concurrency: jobs: require-label: - uses: autowarefoundation/autoware-github-actions/.github/workflows/require-label.yaml@v1 + uses: autowarefoundation/autoware-github-actions/.github/workflows/require-label.yaml@fix/require-label-output with: label: run:build-and-test-differential From 6da66e29ce6c6a5ff6d33e3d04c02a833bc0db5a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Mon, 30 Dec 2024 19:04:12 +0300 Subject: [PATCH 10/15] use v1 of require-label branch again MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .github/workflows/build-test-tidy-pr.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index 12685d491b405..c0442694b5c77 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -14,7 +14,7 @@ concurrency: jobs: require-label: - uses: autowarefoundation/autoware-github-actions/.github/workflows/require-label.yaml@fix/require-label-output + uses: autowarefoundation/autoware-github-actions/.github/workflows/require-label.yaml@v1 with: label: run:build-and-test-differential From c360775c7f9c49cec08eff17b09db00d73ce5af8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Mon, 30 Dec 2024 14:48:17 +0300 Subject: [PATCH 11/15] normal package - good change MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .../include/mission_details_display.hpp | 1 + 1 file changed, 1 insertion(+) diff --git a/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp b/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp index c3db6a2fec2ef..7ed0aacab13ae 100644 --- a/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp +++ b/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp @@ -34,6 +34,7 @@ #include #endif +// Good change test namespace autoware::mission_details_overlay_rviz_plugin { class MissionDetailsDisplay : public rviz_common::Display From 69a8dfab24f12e42351c74850d2120e0a89d7e1e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Mon, 30 Dec 2024 14:56:22 +0300 Subject: [PATCH 12/15] normal package - bad change MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .../include/mission_details_display.hpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp b/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp index 7ed0aacab13ae..66b63b34da493 100644 --- a/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp +++ b/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp @@ -24,7 +24,7 @@ #include #include #include -#include +#include #include #include @@ -34,7 +34,6 @@ #include #endif -// Good change test namespace autoware::mission_details_overlay_rviz_plugin { class MissionDetailsDisplay : public rviz_common::Display From 86186e1b26a10e9836e54b62ed38eed4d21a3ba4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Mon, 23 Dec 2024 00:34:38 +0300 Subject: [PATCH 13/15] cuda package - good change MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .../autoware_lidar_apollo_instance_segmentation/src/node.cpp | 1 + .../include/mission_details_display.hpp | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp b/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp index 9a3e13b81120f..389fbef8f2daa 100644 --- a/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp +++ b/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp @@ -21,6 +21,7 @@ #include +// good change namespace autoware { namespace lidar_apollo_instance_segmentation diff --git a/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp b/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp index 66b63b34da493..c3db6a2fec2ef 100644 --- a/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp +++ b/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp @@ -24,7 +24,7 @@ #include #include #include -#include +#include #include #include From bc6e05118482e131813540c9fe8ad7423f8ac07b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Mon, 23 Dec 2024 02:13:24 +0300 Subject: [PATCH 14/15] cuda package - bad change MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .../autoware_lidar_apollo_instance_segmentation/src/node.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp b/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp index 389fbef8f2daa..a0dd06e614c55 100644 --- a/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp +++ b/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp @@ -17,11 +17,10 @@ #include "autoware/lidar_apollo_instance_segmentation/detector.hpp" #include -#include +#include #include -// good change namespace autoware { namespace lidar_apollo_instance_segmentation From 2c40d9d4e8cf21c2a4023b146c3ff22caeca3f1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Mon, 30 Dec 2024 17:26:30 +0300 Subject: [PATCH 15/15] revert test changes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .../autoware_lidar_apollo_instance_segmentation/src/node.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp b/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp index a0dd06e614c55..9a3e13b81120f 100644 --- a/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp +++ b/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp @@ -17,7 +17,7 @@ #include "autoware/lidar_apollo_instance_segmentation/detector.hpp" #include -#include +#include #include