fix
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
May 30, 2024 in 39s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method motion_velocity_smoother_node.cpp: MotionVelocitySmootherNode::onParameter
✅ Improving Code Health:
- Overall Code Complexity motion_velocity_smoother_node.cpp
Annotations
Check warning on line 203 in planning/motion_velocity_smoother/src/motion_velocity_smoother_node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
MotionVelocitySmootherNode::onParameter already has high cyclomatic complexity, and now it increases in Lines of Code from 121 to 124. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in planning/motion_velocity_smoother/src/motion_velocity_smoother_node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.03 to 4.03, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Loading