From 041d780bc33bd45b88fc0e323fe8b8cc959c9d63 Mon Sep 17 00:00:00 2001 From: satoshi-ota Date: Tue, 7 Nov 2023 14:38:59 +0900 Subject: [PATCH 1/4] chore(config): remove behavior launch modules Signed-off-by: satoshi-ota --- .../behavior_velocity_planner.param.yaml | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/autoware_launch/config/planning/scenario_planning/lane_driving/behavior_planning/behavior_velocity_planner/behavior_velocity_planner.param.yaml b/autoware_launch/config/planning/scenario_planning/lane_driving/behavior_planning/behavior_velocity_planner/behavior_velocity_planner.param.yaml index 7a0ef047f7..aa51c38b55 100644 --- a/autoware_launch/config/planning/scenario_planning/lane_driving/behavior_planning/behavior_velocity_planner/behavior_velocity_planner.param.yaml +++ b/autoware_launch/config/planning/scenario_planning/lane_driving/behavior_planning/behavior_velocity_planner/behavior_velocity_planner.param.yaml @@ -8,19 +8,3 @@ system_delay: 0.5 delay_response_time: 0.5 is_publish_debug_path: false # publish all debug path with lane id in each module - launch_modules: - - behavior_velocity_planner::CrosswalkModulePlugin - - behavior_velocity_planner::WalkwayModulePlugin - - behavior_velocity_planner::TrafficLightModulePlugin - - behavior_velocity_planner::IntersectionModulePlugin # Intersection module should be before merge from private to declare intersection parameters. - - behavior_velocity_planner::MergeFromPrivateModulePlugin - - behavior_velocity_planner::BlindSpotModulePlugin - - behavior_velocity_planner::DetectionAreaModulePlugin - # behavior_velocity_planner::VirtualTrafficLightModulePlugin - - behavior_velocity_planner::NoStoppingAreaModulePlugin # No stopping area module requires all the stop line. Therefore this modules should be placed at the bottom. - - behavior_velocity_planner::StopLineModulePlugin # Permanent stop line module should be after no stopping area - # behavior_velocity_planner::OcclusionSpotModulePlugin - # behavior_velocity_planner::RunOutModulePlugin - # behavior_velocity_planner::SpeedBumpModulePlugin - - behavior_velocity_planner::OutOfLaneModulePlugin - # behavior_velocity_planner::NoDrivableLaneModulePlugin From ef875f7c99b06ab9f10190bf2df727997f8ee370 Mon Sep 17 00:00:00 2001 From: satoshi-ota Date: Tue, 7 Nov 2023 14:39:54 +0900 Subject: [PATCH 2/4] refactor(config): add preset yaml file Signed-off-by: satoshi-ota --- .../planning/preset/default_preset.yaml | 87 +++++++++++++++++++ 1 file changed, 87 insertions(+) create mode 100644 autoware_launch/config/planning/preset/default_preset.yaml diff --git a/autoware_launch/config/planning/preset/default_preset.yaml b/autoware_launch/config/planning/preset/default_preset.yaml new file mode 100644 index 0000000000..c713ad0488 --- /dev/null +++ b/autoware_launch/config/planning/preset/default_preset.yaml @@ -0,0 +1,87 @@ +launch: + # - arg: + # name: behavior_path_planner_launch_modules + # default: "[behavior_path_planner::Avoidance, + # behavior_path_planner::AvoidanceByLaneChange, + # behavior_path_planner::DynamicAvoidance, + # behavior_path_planner::LaneChange, + # behavior_path_planner::ExternalLaneChange, + # behavior_path_planner::StartPlanner, + # behavior_path_planner::GoalPlanner, + # behavior_path_planner::SideShift]" + # # option: behavior_path_planner::Avoidance + # # behavior_path_planner::AvoidanceByLaneChange + # # behavior_path_planner::DynamicAvoidance + # # behavior_path_planner::LaneChange + # # behavior_path_planner::ExternalLaneChange + # # behavior_path_planner::StartPlanner + # # behavior_path_planner::GoalPlanner + # # behavior_path_planner::SideShift" + + - arg: + name: behavior_velocity_planner_launch_modules + default: "[behavior_velocity_planner::CrosswalkModulePlugin, + behavior_velocity_planner::WalkwayModulePlugin, + behavior_velocity_planner::TrafficLightModulePlugin, + behavior_velocity_planner::IntersectionModulePlugin, + behavior_velocity_planner::MergeFromPrivateModulePlugin, + behavior_velocity_planner::BlindSpotModulePlugin, + behavior_velocity_planner::DetectionAreaModulePlugin, + behavior_velocity_planner::NoStoppingAreaModulePlugin, + behavior_velocity_planner::StopLineModulePlugin, + behavior_velocity_planner::OutOfLaneModulePlugin]" + # option: behavior_velocity_planner::CrosswalkModulePlugin + # behavior_velocity_planner::WalkwayModulePlugin + # behavior_velocity_planner::TrafficLightModulePlugin + # behavior_velocity_planner::IntersectionModulePlugin + # behavior_velocity_planner::MergeFromPrivateModulePlugin + # behavior_velocity_planner::BlindSpotModulePlugin + # behavior_velocity_planner::DetectionAreaModulePlugin + # behavior_velocity_planner::VirtualTrafficLightModulePlugin + # behavior_velocity_planner::NoStoppingAreaModulePlugin + # behavior_velocity_planner::StopLineModulePlugin + # behavior_velocity_planner::OcclusionSpotModulePlugin + # behavior_velocity_planner::RunOutModulePlugin + # behavior_velocity_planner::SpeedBumpModulePlugin + # behavior_velocity_planner::OutOfLaneModulePlugin + # behavior_velocity_planner::NoDrivableLaneModulePlugin" + + - arg: + name: use_experimental_lane_change_function + default: "true" + + - arg: + name: launch_surround_obstacle_checker + default: "true" + + - arg: + name: motion_path_smoother_type + default: elastic_band + # option: elastic_band + # none + + - arg: + name: motion_path_planner_type + default: obstacle_avoidance_planner + # option: obstacle_avoidance_planner + # path_sampler + # none + + - arg: + name: motion_stop_planner_type + default: obstacle_stop_planner + # option: obstacle_stop_planner + # obstacle_cruise_planner + # none + + - arg: + name: motion_velocity_smoother_type + default: JerkFiltered + # option: JerkFiltered + # L2 + # Linf(Unstable) + # Analytical + + - arg: + name: launch_parking_module + default: "true" From b543565f9f61c70a2eaafb27322878b02b385646 Mon Sep 17 00:00:00 2001 From: satoshi-ota Date: Tue, 7 Nov 2023 14:45:01 +0900 Subject: [PATCH 3/4] refactor(launch): add new option to select planning preset Signed-off-by: satoshi-ota --- .../planning/preset/default_preset.yaml | 127 +++++++++++------- .../scene_module_manager.param.yaml | 10 -- autoware_launch/launch/autoware.launch.xml | 7 +- .../tier4_planning_component.launch.xml | 24 +--- .../launch/e2e_simulator.launch.xml | 5 + .../launch/logging_simulator.launch.xml | 5 + .../launch/planning_simulator.launch.xml | 5 + 7 files changed, 107 insertions(+), 76 deletions(-) diff --git a/autoware_launch/config/planning/preset/default_preset.yaml b/autoware_launch/config/planning/preset/default_preset.yaml index c713ad0488..a6f2ed025d 100644 --- a/autoware_launch/config/planning/preset/default_preset.yaml +++ b/autoware_launch/config/planning/preset/default_preset.yaml @@ -1,59 +1,87 @@ launch: - # - arg: - # name: behavior_path_planner_launch_modules - # default: "[behavior_path_planner::Avoidance, - # behavior_path_planner::AvoidanceByLaneChange, - # behavior_path_planner::DynamicAvoidance, - # behavior_path_planner::LaneChange, - # behavior_path_planner::ExternalLaneChange, - # behavior_path_planner::StartPlanner, - # behavior_path_planner::GoalPlanner, - # behavior_path_planner::SideShift]" - # # option: behavior_path_planner::Avoidance - # # behavior_path_planner::AvoidanceByLaneChange - # # behavior_path_planner::DynamicAvoidance - # # behavior_path_planner::LaneChange - # # behavior_path_planner::ExternalLaneChange - # # behavior_path_planner::StartPlanner - # # behavior_path_planner::GoalPlanner - # # behavior_path_planner::SideShift" - + # behavior path modules - arg: - name: behavior_velocity_planner_launch_modules - default: "[behavior_velocity_planner::CrosswalkModulePlugin, - behavior_velocity_planner::WalkwayModulePlugin, - behavior_velocity_planner::TrafficLightModulePlugin, - behavior_velocity_planner::IntersectionModulePlugin, - behavior_velocity_planner::MergeFromPrivateModulePlugin, - behavior_velocity_planner::BlindSpotModulePlugin, - behavior_velocity_planner::DetectionAreaModulePlugin, - behavior_velocity_planner::NoStoppingAreaModulePlugin, - behavior_velocity_planner::StopLineModulePlugin, - behavior_velocity_planner::OutOfLaneModulePlugin]" - # option: behavior_velocity_planner::CrosswalkModulePlugin - # behavior_velocity_planner::WalkwayModulePlugin - # behavior_velocity_planner::TrafficLightModulePlugin - # behavior_velocity_planner::IntersectionModulePlugin - # behavior_velocity_planner::MergeFromPrivateModulePlugin - # behavior_velocity_planner::BlindSpotModulePlugin - # behavior_velocity_planner::DetectionAreaModulePlugin - # behavior_velocity_planner::VirtualTrafficLightModulePlugin - # behavior_velocity_planner::NoStoppingAreaModulePlugin - # behavior_velocity_planner::StopLineModulePlugin - # behavior_velocity_planner::OcclusionSpotModulePlugin - # behavior_velocity_planner::RunOutModulePlugin - # behavior_velocity_planner::SpeedBumpModulePlugin - # behavior_velocity_planner::OutOfLaneModulePlugin - # behavior_velocity_planner::NoDrivableLaneModulePlugin" - + name: launch_avoidance_module + default: "true" + - arg: + name: launch_avoidance_by_lane_change_module + default: "true" + - arg: + name: launch_dynamic_avoidance_module + default: "false" + - arg: + name: launch_lane_change_right_module + default: "true" + - arg: + name: launch_lane_change_left_module + default: "true" + - arg: + name: launch_external_request_lane_change_right_module + default: "false" + - arg: + name: launch_external_request_lane_change_left_module + default: "false" + - arg: + name: launch_goal_planner_module + default: "true" + - arg: + name: launch_start_planner_module + default: "true" + - arg: + name: launch_side_shift_module + default: "true" - arg: name: use_experimental_lane_change_function default: "true" + # behavior velocity modules - arg: - name: launch_surround_obstacle_checker + name: launch_crosswalk_module + default: "true" + - arg: + name: launch_walkway_module + default: "true" + - arg: + name: launch_traffic_light_module default: "true" + - arg: + name: launch_intersection_module + default: "true" + - arg: + name: launch_merge_from_private_module + default: "true" + - arg: + name: launch_blind_spot_module + default: "true" + - arg: + name: launch_detection_area_module + default: "true" + - arg: + name: launch_virtual_traffic_light_module + default: "false" + - arg: + name: launch_no_stopping_area_module + default: "true" + - arg: + name: launch_stop_line_module + default: "true" + - arg: + name: launch_occlusion_spot_module + default: "false" + - arg: + name: launch_run_out_module + default: "false" + - arg: + name: launch_speed_bump_module + default: "false" + - arg: + name: launch_out_of_lane_module + default: "true" + - arg: + name: launch_no_drivable_lane_module + default: "false" + # motion planning modules - arg: name: motion_path_smoother_type default: elastic_band @@ -82,6 +110,11 @@ launch: # Linf(Unstable) # Analytical + - arg: + name: launch_surround_obstacle_checker + default: "true" + + # parking modules - arg: name: launch_parking_module default: "true" diff --git a/autoware_launch/config/planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/scene_module_manager.param.yaml b/autoware_launch/config/planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/scene_module_manager.param.yaml index 1fc83edd08..0090a29926 100644 --- a/autoware_launch/config/planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/scene_module_manager.param.yaml +++ b/autoware_launch/config/planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/scene_module_manager.param.yaml @@ -4,7 +4,6 @@ /**: ros__parameters: external_request_lane_change_left: - enable_module: false enable_rtc: false enable_simultaneous_execution_as_approved_module: false enable_simultaneous_execution_as_candidate_module: true @@ -13,7 +12,6 @@ max_module_size: 1 external_request_lane_change_right: - enable_module: false enable_rtc: false enable_simultaneous_execution_as_approved_module: false enable_simultaneous_execution_as_candidate_module: true @@ -22,7 +20,6 @@ max_module_size: 1 lane_change_left: - enable_module: true enable_rtc: false enable_simultaneous_execution_as_approved_module: true enable_simultaneous_execution_as_candidate_module: true @@ -31,7 +28,6 @@ max_module_size: 1 lane_change_right: - enable_module: true enable_rtc: false enable_simultaneous_execution_as_approved_module: true enable_simultaneous_execution_as_candidate_module: true @@ -40,7 +36,6 @@ max_module_size: 1 start_planner: - enable_module: true enable_rtc: false enable_simultaneous_execution_as_approved_module: true enable_simultaneous_execution_as_candidate_module: false @@ -49,7 +44,6 @@ max_module_size: 1 side_shift: - enable_module: true enable_rtc: false enable_simultaneous_execution_as_approved_module: false enable_simultaneous_execution_as_candidate_module: false @@ -58,7 +52,6 @@ max_module_size: 1 goal_planner: - enable_module: true enable_rtc: false enable_simultaneous_execution_as_approved_module: false enable_simultaneous_execution_as_candidate_module: false @@ -67,7 +60,6 @@ max_module_size: 1 avoidance: - enable_module: true enable_rtc: false enable_simultaneous_execution_as_approved_module: true enable_simultaneous_execution_as_candidate_module: false @@ -76,7 +68,6 @@ max_module_size: 1 avoidance_by_lc: - enable_module: true enable_rtc: false enable_simultaneous_execution_as_approved_module: false enable_simultaneous_execution_as_candidate_module: false @@ -85,7 +76,6 @@ max_module_size: 1 dynamic_avoidance: - enable_module: false enable_rtc: false enable_simultaneous_execution_as_approved_module: true enable_simultaneous_execution_as_candidate_module: true diff --git a/autoware_launch/launch/autoware.launch.xml b/autoware_launch/launch/autoware.launch.xml index 5d98c9388f..80822d0146 100644 --- a/autoware_launch/launch/autoware.launch.xml +++ b/autoware_launch/launch/autoware.launch.xml @@ -8,6 +8,9 @@ + + + @@ -98,7 +101,9 @@ - + + + diff --git a/autoware_launch/launch/components/tier4_planning_component.launch.xml b/autoware_launch/launch/components/tier4_planning_component.launch.xml index 5f14006f7a..5fb17541cd 100644 --- a/autoware_launch/launch/components/tier4_planning_component.launch.xml +++ b/autoware_launch/launch/components/tier4_planning_component.launch.xml @@ -1,24 +1,8 @@ - - - - - - - - - - - - - - - - - - + + @@ -26,6 +10,7 @@ + @@ -34,6 +19,7 @@ + @@ -46,6 +32,7 @@ + @@ -68,6 +55,7 @@ + diff --git a/autoware_launch/launch/e2e_simulator.launch.xml b/autoware_launch/launch/e2e_simulator.launch.xml index fe8d1de1d8..d920584c6c 100644 --- a/autoware_launch/launch/e2e_simulator.launch.xml +++ b/autoware_launch/launch/e2e_simulator.launch.xml @@ -6,6 +6,9 @@ + + + @@ -43,6 +46,8 @@ + + diff --git a/autoware_launch/launch/logging_simulator.launch.xml b/autoware_launch/launch/logging_simulator.launch.xml index 7eb13135d3..a2b66e91ed 100644 --- a/autoware_launch/launch/logging_simulator.launch.xml +++ b/autoware_launch/launch/logging_simulator.launch.xml @@ -7,6 +7,9 @@ + + + @@ -39,6 +42,8 @@ + + diff --git a/autoware_launch/launch/planning_simulator.launch.xml b/autoware_launch/launch/planning_simulator.launch.xml index fdc86ebba7..28a0f0e347 100644 --- a/autoware_launch/launch/planning_simulator.launch.xml +++ b/autoware_launch/launch/planning_simulator.launch.xml @@ -6,6 +6,9 @@ + + + @@ -39,6 +42,8 @@ + + From bc6694afa541bd061d840fd7f2995208163e081a Mon Sep 17 00:00:00 2001 From: satoshi-ota Date: Wed, 8 Nov 2023 13:31:19 +0900 Subject: [PATCH 4/4] refactor(config): remove unused params Signed-off-by: satoshi-ota --- .../behavior_path_planner/behavior_path_planner.param.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/autoware_launch/config/planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/behavior_path_planner.param.yaml b/autoware_launch/config/planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/behavior_path_planner.param.yaml index 6acbe9783d..8d93a95b37 100644 --- a/autoware_launch/config/planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/behavior_path_planner.param.yaml +++ b/autoware_launch/config/planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/behavior_path_planner.param.yaml @@ -5,9 +5,6 @@ traffic_light_signal_timeout: 1.0 - groot_zmq_publisher_port: 1666 - groot_zmq_server_port: 1667 - planning_hz: 10.0 backward_path_length: 5.0 forward_path_length: 300.0