Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the parameter name of max_vel #907

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix: the parameter name of max_vel #907

merged 1 commit into from
Mar 6, 2024

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Mar 6, 2024

Description

The parameter's name was changed unexpectedly by the following PR.
#763

Part of:

Tests performed

simple planning simulator

Effects on system behavior

The parameter will be correctly loaded.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 marked this pull request as ready for review March 6, 2024 13:34
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168
Copy link
Contributor Author

@xmfcx
Sorry, since the PR to change the maximum velocity is an old one, the parameter's name was not correct. I fixed it.

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for overlooking this in the review 😯

@xmfcx xmfcx merged commit e14eabe into main Mar 6, 2024
10 of 11 checks passed
@xmfcx xmfcx deleted the fix/max-vel branch March 6, 2024 13:38
satoshi-ota pushed a commit to tier4/autoware_launch that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants