Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(system diags): rename diag of ndt scan matcher #973

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented Apr 25, 2024

Description

see autowarefoundation/autoware.universe#6889

Tests performed

see autowarefoundation/autoware.universe#6889

Effects on system behavior

see autowarefoundation/autoware.universe#6889

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yamato Ando <[email protected]>
@YamatoAndo
Copy link
Contributor Author

YamatoAndo commented Apr 26, 2024

@ito-san @isamu-takagi @takayuki5168 @rej55 @satoshi-ota @shmpwk
autowarefoundation/autoware.universe#6889 has been merged, so I'd like to merge this PR as soon as possible.
Could you please review this PR?

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ito-san ito-san added enhancement New feature or request component:system System design and integration. (auto-assigned) labels Apr 26, 2024
@ito-san ito-san enabled auto-merge (squash) April 26, 2024 09:25
Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YamatoAndo
Copy link
Contributor Author

@takayuki5168 @rej55 @satoshi-ota @shmpwk
please review 🙇

@ito-san ito-san merged commit 9196c58 into autowarefoundation:main Apr 30, 2024
12 of 13 checks passed
Ericpotato added a commit to tier4/autoware_launch that referenced this pull request Nov 6, 2024
…utowarefoundation#973)

* add hardware and sensing settings for diagnostic_graph_aggregator to replace system_error_monitoring

Signed-off-by: Ericpotato <[email protected]>

* typo fixed

Signed-off-by: Ericpotato <[email protected]>

* style(pre-commit): autofix

* typo fixed

Signed-off-by: Ericpotato <[email protected]>

* change config file name to autoware-main to sync

Signed-off-by: Ericpotato <[email protected]>

* change diagnostic_graph_aggregator config file name to autoware-main

Signed-off-by: Ericpotato <[email protected]>

* update autoware-psim setting

Signed-off-by: Ericpotato <[email protected]>

* style(pre-commit): autofix

* customize diagnostic_graph_aggregator config to target to autoware-main_xx1

Signed-off-by: Ericpotato <[email protected]>

* fix reference path of autoware-psim

Signed-off-by: Ericpotato <[email protected]>

* use default config files name, remove files with _xx1 suffix

Signed-off-by: Ericpotato <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Ericpotato <[email protected]>
Co-authored-by: Ericpotato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants