Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update package.xml and fix CMakeLists.txt #91

Merged
merged 1 commit into from
May 10, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented May 10, 2024

Description

This PR has updated package.xml and CMakeLists.txt for each package to prepare releasing from ROS build farm.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@youtalk youtalk marked this pull request as ready for review May 10, 2024 06:16
@youtalk youtalk self-assigned this May 10, 2024
@youtalk
Copy link
Member Author

youtalk commented May 10, 2024

clang-tidy-differential is still being broken. I'll try to fix it on the other PR.
https://github.com/autowarefoundation/autoware_msgs/actions/runs/9028098716/job/24808131513?pr=91

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk requested a review from xmfcx May 10, 2024 06:40
Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk merged commit 8e657ab into autowarefoundation:main May 10, 2024
10 of 11 checks passed
@youtalk youtalk deleted the update-package-xml branch May 10, 2024 08:33
@@ -3,9 +3,10 @@
<package format="3">
<name>autoware_vehicle_msgs</name>
<version>1.0.0</version>
<description>Interfaces between core Autoware.Auto vehicle components</description>
<description>Interfaces between core Autoware vehicle components</description>
<maintainer email="[email protected]">Apex.AI, Inc.</maintainer>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beginningfan You might want to update this line. (In another PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants