Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(awsim_labs_sensor_kit_launch): add autoware prefix to vehicle_velocity_converter #11

Conversation

a-maumau
Copy link

Description

This PR will add the autoware prefix to vehicle_velocity_converter due to the changes in autowarefoundation/autoware.universe#8967 .

This should merge with autowarefoundation/autoware.universe#8967

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@shmpwk
Copy link

shmpwk commented Dec 6, 2024

@mitsudome-r
Could you merge this PR? I don't have permission to merge this PR.

@xmfcx xmfcx force-pushed the mau/fix/sensing/vehicle_velocity_converter branch from 9e2de62 to ffdd840 Compare December 16, 2024 12:35
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx
Copy link

xmfcx commented Dec 16, 2024

@a-maumau @shmpwk I've set up the team permissions, you should be able to merge from now on 👍
Sorry for the inconvenience 🙇‍♂️

@xmfcx xmfcx merged commit 15342ec into autowarefoundation:main Dec 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants