Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translations: init german #20

Merged
merged 13 commits into from
May 10, 2024
Merged

translations: init german #20

merged 13 commits into from
May 10, 2024

Conversation

dantefromhell
Copy link
Member

Currently draft for early reviews,should use a squash commit once finished.

@dantefromhell
Copy link
Member Author

@mrshmllow mrshmllow added the translation Translation of existing documentation label May 7, 2024
Copy link

@liketechnik liketechnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great so far, thank you for getting started with this and the translation work you already did!

I hope you don't mind the many cases in which I've simply suggested different things without much reasoning - I find it quite difficult to express what exactly makes the difference between the current translation and my proposals. But feel free to suggest a different way of reviewing this, if you feel uncomfortable with my style of doing this.

public/locales/de/translations.json Show resolved Hide resolved
public/locales/de/translations.json Outdated Show resolved Hide resolved
public/locales/de/translations.json Outdated Show resolved Hide resolved
public/locales/de/translations.json Show resolved Hide resolved
public/locales/de/translations.json Outdated Show resolved Hide resolved
public/locales/de/translations.json Outdated Show resolved Hide resolved
public/locales/de/translations.json Outdated Show resolved Hide resolved
public/locales/de/translations.json Outdated Show resolved Hide resolved
@dantefromhell
Copy link
Member Author

@christoph-heiss @liketechnik
I finished the translation and incorporated your previous feedback.

Please give it another round of in-depth reviewing.

@dantefromhell dantefromhell marked this pull request as ready for review May 8, 2024 01:02
public/locales/de/translations.json Outdated Show resolved Hide resolved
public/locales/de/translations.json Outdated Show resolved Hide resolved
public/locales/de/translations.json Outdated Show resolved Hide resolved
public/locales/de/translations.json Outdated Show resolved Hide resolved
public/locales/de/translations.json Outdated Show resolved Hide resolved
public/locales/de/translations.json Outdated Show resolved Hide resolved
@dantefromhell
Copy link
Member Author

@mrshmllow Translation complete, can you plz take a look and squash commit if all is good?

Thanks

@mrshmllow mrshmllow merged commit 8c84a59 into auxolotl:main May 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translation of existing documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants